[TBB] Use another repo/branch/tag for PPC #7051

mrodozov · 2021-06-21T12:42:53Z

Patching our current tag v2021.2.0 isn't possible (the PR is over latest master and has too many changes compared with 21.2.0)
Even if we could've used that patch it's ~500 lines
Third option will be to fork oneTBB which will save one line - github_user

Patching our current tag v2021.2.0 isn't possible (the PR is over latest master and has too many changes compared with 21.2.0) Even if we could've used that patch it's ~500 line Third option will be to fork oneTBB which will save one line - github_user

cmsbuild · 2021-06-21T12:43:13Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

makortel · 2021-06-21T13:11:29Z

Given that we've seen the failures in ARM too, should the TBB be updated similarly for ARM too?

mrodozov · 2021-06-21T13:45:07Z

let's check it then

mrodozov · 2021-06-21T13:45:15Z

please test

mrodozov · 2021-06-21T13:45:59Z

please test for CMSSW_12_0_X/slc7_ppc64le_gcc9

mrodozov · 2021-06-21T13:46:55Z

please test for CMSSW_12_0_X/slc7_aarch64_gcc9

mrodozov · 2021-06-21T13:48:15Z

but umm ... I don't recall any issue related to ARM similar to this
cms-sw/cmssw#33636
they are 1325.* -> config
280.0 -> probably uninit values
one more that is now fixed

makortel · 2021-06-21T13:55:56Z

See @dan131riley's comment cms-sw/cmssw#33636 (comment). Maybe the crash is more rare on ARM than on PPC?

cmsbuild · 2021-06-21T14:01:20Z

Pull request #7051 was updated.

mrodozov · 2021-06-21T14:01:55Z

please test

mrodozov · 2021-06-21T14:02:17Z

please test for CMSSW_12_0_X/slc7_ppc64le_gcc9

mrodozov · 2021-06-21T14:02:52Z

please test for CMSSW_12_0_X/slc7_aarch64_gcc9

cmsbuild · 2021-06-21T21:18:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b60a6b/16137/summary.html
COMMIT: 8674aed
CMSSW: CMSSW_12_0_X_2021-06-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7051/16137/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

[BuildRules] Add unit test time in the test logs #7045 @cms-sw: [BuildRules] Add unit test time in the test logs
Update tag for L1Trigger-CSCTriggerPrimitives to V00-09-00 #7046 @cms-sw: Update tag for L1Trigger-CSCTriggerPrimitives to V00-09-00

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b60a6b/16137/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b60a6b/16137/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2785631
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2785602
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-06-22T01:33:59Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b60a6b/16141/summary.html
COMMIT: 8674aed
CMSSW: CMSSW_12_0_X_2021-06-21-1100/slc7_aarch64_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7051/16141/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestFWCoreServicesDriver had ERRORS
---> test TestConfigDP had ERRORS

cmsbuild · 2021-06-22T07:42:17Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b60a6b/16138/summary.html
COMMIT: 8674aed
CMSSW: CMSSW_12_0_X_2021-06-20-2300/slc7_ppc64le_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7051/16138/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

[BuildRules] Add unit test time in the test logs #7045 @cms-sw: [BuildRules] Add unit test time in the test logs
Update tag for L1Trigger-CSCTriggerPrimitives to V00-09-00 #7046 @cms-sw: Update tag for L1Trigger-CSCTriggerPrimitives to V00-09-00

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b60a6b/16138/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b60a6b/16138/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_PrepareInputDb had ERRORS
---> test test_MpsWorkFlow had ERRORS
---> test testFWCoreUtilities had ERRORS
---> test TestHeterogeneousCoreSonicTritonProducerGPU had ERRORS
and more ...

smuzaffar · 2021-06-22T08:06:24Z

test parameters:

enable_test = threading
workflow_threading = 4000.0,23234.9,23434.99,34634.0,34834.999,35034.0,36234.0,36634.0,37434.0

smuzaffar · 2021-06-22T08:06:38Z

please test for CMSSW_12_0_X/slc7_aarch64_gcc9

smuzaffar · 2021-06-22T08:06:51Z

please test for CMSSW_12_0_X/slc7_ppc64le_gcc9

cmsbuild · 2021-06-22T14:17:02Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b60a6b/16152/summary.html
COMMIT: 8674aed
CMSSW: CMSSW_12_0_X_2021-06-21-2300/slc7_aarch64_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7051/16152/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testFWCoreUtilities had ERRORS
---> test TestFWCoreServicesDriver had ERRORS
---> test TestConfigDP had ERRORS

cmsbuild · 2021-06-22T18:01:05Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b60a6b/16155/summary.html
COMMIT: 8674aed
CMSSW: CMSSW_12_0_X_2021-06-21-2300/slc7_ppc64le_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7051/16155/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_PrepareInputDb had ERRORS
---> test test_MpsWorkFlow had ERRORS
---> test TestHeterogeneousCoreSonicTritonProducerGPU had ERRORS
---> test testAlignmentOfflineValidation had ERRORS
and more ...

smuzaffar · 2021-06-22T21:01:38Z

+externals
looks good, lets get this in

cmsbuild · 2021-06-22T21:01:57Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Jun 21, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 21, 2021

include the patch also for ARM

8674aed

cmsbuild added tests-pending and removed tests-started labels Jun 21, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 21, 2021

cmsbuild added tests-approved and removed tests-started labels Jun 21, 2021

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Jun 22, 2021

smuzaffar merged commit cae3c01 into IB/CMSSW_12_0_X/master Jun 22, 2021

mrodozov deleted the mrodozov-patch-4 branch June 23, 2021 06:42

cmsbuild mentioned this pull request Jun 23, 2021

Get catch2 2.13.6 #7053

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TBB] Use another repo/branch/tag for PPC #7051

[TBB] Use another repo/branch/tag for PPC #7051

mrodozov commented Jun 21, 2021 •

edited

Loading

cmsbuild commented Jun 21, 2021

makortel commented Jun 21, 2021

mrodozov commented Jun 21, 2021

mrodozov commented Jun 21, 2021

mrodozov commented Jun 21, 2021

mrodozov commented Jun 21, 2021

mrodozov commented Jun 21, 2021

makortel commented Jun 21, 2021

cmsbuild commented Jun 21, 2021

mrodozov commented Jun 21, 2021

mrodozov commented Jun 21, 2021

mrodozov commented Jun 21, 2021

cmsbuild commented Jun 21, 2021

cmsbuild commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

smuzaffar commented Jun 22, 2021

smuzaffar commented Jun 22, 2021

smuzaffar commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

smuzaffar commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

[TBB] Use another repo/branch/tag for PPC #7051

[TBB] Use another repo/branch/tag for PPC #7051

Conversation

mrodozov commented Jun 21, 2021 • edited Loading

cmsbuild commented Jun 21, 2021

makortel commented Jun 21, 2021

mrodozov commented Jun 21, 2021

mrodozov commented Jun 21, 2021

mrodozov commented Jun 21, 2021

mrodozov commented Jun 21, 2021

mrodozov commented Jun 21, 2021

makortel commented Jun 21, 2021

cmsbuild commented Jun 21, 2021

mrodozov commented Jun 21, 2021

mrodozov commented Jun 21, 2021

mrodozov commented Jun 21, 2021

cmsbuild commented Jun 21, 2021

Comparison Summary

cmsbuild commented Jun 22, 2021

Unit Tests

cmsbuild commented Jun 22, 2021

Unit Tests

smuzaffar commented Jun 22, 2021

smuzaffar commented Jun 22, 2021

smuzaffar commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

Unit Tests

cmsbuild commented Jun 22, 2021

Unit Tests

smuzaffar commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

mrodozov commented Jun 21, 2021 •

edited

Loading