-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another set of python2 tools to be removed #6962
Conversation
test parameters:
|
please test |
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_0_X/master. @cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
@davidlange6 , looks like this contains the changes of #6955 too ..right? |
Yes, this contains #6955. I don’t remember why we added cryptography - I’ll try to remind myself. Perhaps indeed its not needed.
… On Jun 2, 2021, at 10:08 AM, Malik Shahzad Muzaffar ***@***.***> wrote:
@davidlange6 , looks like this contains the changes of #6955 too ..right?
Can we drop cryptography too as no packages requires it any more (only pyOpenSSL was using it)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I don't find anything that suggests that the cryptography package is important for some use case - I'll drop cryptography when I next update this (or in the next PR in case this one doesn't need updating) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-007cf0/15537/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
No description provided.