Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove root_numpy and root_pandas on cmsdist master #6896

Merged

Conversation

mrodozov
Copy link
Contributor

while testing ROOT master integration, compilation failed due to unmaintained root_numpy
It's not compiling anymore with ROOT master, this is a request to remove both from everywhere

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

please test with cms-sw/cmssw#33707

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63fe77/15028/summary.html
COMMIT: 5e65fb7
CMSSW: CMSSW_12_0_X_2021-05-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6896/15028/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63fe77/15028/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63fe77/15028/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2648114
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2648091
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@mrodozov mrodozov merged commit fef92f1 into cms-sw:IB/CMSSW_12_0_X/master May 13, 2021
@smuzaffar
Copy link
Contributor

@mrodozov , please revert this change this broken DQM Bin by bin PR comparison cms-sw/cmssw#33610 (comment)

@jfernan2
Copy link

Thanks a lot @smuzaffar

jfernan2 added a commit to jfernan2/cmssw that referenced this pull request May 17, 2021
Due to unmaintainance of the packet as proposed here: 
cms-sw/cmsdist#6896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants