Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for RecoBTag-Combined to V01-07-01-01-00 #6881

Merged
merged 1 commit into from
May 11, 2021

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented May 6, 2021

this is needed in 10_6
cms-data/RecoBTag-Combined#45
needed for cms-sw/cmssw#33588

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@jpata
Copy link

jpata commented May 7, 2021

sorry to bother, but just to make sure it's not stuck behind me - could the test be started, can I do it myself?

@mrodozov
Copy link
Contributor Author

mrodozov commented May 7, 2021

allow @jpata test rights

@mrodozov
Copy link
Contributor Author

mrodozov commented May 7, 2021

now you do, but also this was already tested. this only adds the tag that includes the cms-data change to be used

@mrodozov
Copy link
Contributor Author

mrodozov commented May 7, 2021

+externals
when the release manager merge the cmssw PR he'll merge also this

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-646e2d/14932/summary.html
COMMIT: 8e8bff8
CMSSW: CMSSW_10_6_X_2021-05-06-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6881/14932/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215556
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215221
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented May 11, 2021

+1

@cmsbuild cmsbuild merged commit 3b4b118 into IB/CMSSW_10_6_X/gcc700 May 11, 2021
@mrodozov mrodozov deleted the mrodozov-patch-1 branch May 17, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants