Upgrade Herwigpp to Herwig 7.2, in 9_4_X

[Dominic-Stafford]

Upgrades Herwigpp to Herwig 7.2 for use with the Heavy Ion run data. To be tested with cms-sw/cmssw#33492

[cmsbuild]

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_9_4_X/gcc630.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[mrodozov]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a5459/14393/summary.html
COMMIT: 66a96af
CMSSW: CMSSW_9_4_X_2021-04-18-0000/slc6_amd64_gcc630
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6829/14393/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.2.2-e562a5268c1fc00e6884ff1536d6c8ac/include/ThePEG/Pointer/RCPtr.h: In instantiation of 'ThePEG::Pointer::RCPtr& ThePEG::Pointer::RCPtr::create(ThePEG::Pointer::RCPtr::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::RCPtr::const_reference = const ThePEG::LesHouchesInterface&]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.2.2-e562a5268c1fc00e6884ff1536d6c8ac/include/ThePEG/Pointer/RCPtr.h:131:22:   required from 'static ThePEG::Pointer::RCPtr ThePEG::Pointer::RCPtr::Create(ThePEG::Pointer::RCPtr::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::RCPtr::const_reference = const ThePEG::LesHouchesInterface&]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.2.2-e562a5268c1fc00e6884ff1536d6c8ac/include/ThePEG/Pointer/RCPtr.h:889:69:   required from 'static ThePEG::Pointer::PtrTraits >::pointer ThePEG::Pointer::PtrTraits >::create(ThePEG::Pointer::PtrTraits >::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::PtrTraits >::pointer = ThePEG::Pointer::RCPtr; ThePEG::Pointer::PtrTraits >::const_reference = const ThePEG::LesHouchesInterface&]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.2.2-e562a5268c1fc00e6884ff1536d6c8ac/include/ThePEG/Pointer/PtrTraits.h:204:55:   required from 'typename ThePEG::Pointer::Ptr::pointer ThePEG::Pointer::new_ptr(const T&) [with T = ThePEG::LesHouchesInterface; typename ThePEG::Pointer::Ptr::pointer = ThePEG::Pointer::RCPtr]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_9_4_X_2021-04-18-0000/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:38:53:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.2.2-e562a5268c1fc00e6884ff1536d6c8ac/include/ThePEG/Pointer/RCPtr.h:152:11: error: invalid new-expression of abstract class type 'ThePEG::LesHouchesInterface'
     ptr = new T(t);
           ^~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_9_4_X_2021-04-18-0000/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:30:7: note:   because the following virtual functions are pure within 'ThePEG::LesHouchesInterface':
 class LesHouchesInterface : public LesHouchesReader {
       ^~~~~~~~~~~~~~~~~~~


[mrodozov]

please test with cms-sw/cmssw#33492

[mrodozov]

sry, missed the comment

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a5459/14399/summary.html
COMMIT: 66a96af
CMSSW: CMSSW_9_4_X_2021-04-18-0000/slc6_amd64_gcc630
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6829/14399/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 107
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721224
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0
• TriggerResults: no differences found

[mrodozov]

+externals
@silviodonato except #6863

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_4_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)