patching CLEO model for production studies

[alberto-sanchez]

This simple patch in required in order to use this model in MC production.

[cmsbuild]

A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[alberto-sanchez]

please test workflow 541.0, 545.0

[alberto-sanchez]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd6aca/13803/summary.html
COMMIT: 0f6a53a
CMSSW: CMSSW_10_6_X_2021-03-26-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6762/13803/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215541
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215206
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[alberto-sanchez]

Dear @qliphy, @silviodonato, we are interested in having this patch in production asap. We will need to generate some MC samples using this decay model.

This is the distribution before the patch

and, this is the distribution after the patch

[qliphy]

Dear @qliphy, @silviodonato, we are interested in having this patch in production asap. We will need to generate some MC samples using this decay model.

@alberto-sanchez
Thanks! It looks good to me. Adding @smuzaffar @mrodozov @cms-sw/generators-l2
What is the time scale for the MC production?

[smuzaffar]

looks good to me. @alberto-sanchez do we need a similar patch for evtgen 2.0.0 https://github.com/cms-externals/evtgen/blob/cms/2.0.0/src/EvtGenModels/EvtYmSToYnSpipiCLEO.cpp#L145 ?

[alberto-sanchez]

@alberto-sanchez
What is the time scale for the MC production?

As soon as is available

[alberto-sanchez]

looks good to me. @alberto-sanchez do we need a similar patch for evtgen 2.0.0 https://github.com/cms-externals/evtgen/blob/cms/2.0.0/src/EvtGenModels/EvtYmSToYnSpipiCLEO.cpp#L145 ?

Yes, we will need something similar in evtgen 2.0
I wonder how is the best way to go for it. In principle the compilation of 2.0 is different than in 1.6, and we already have a
repo for that in cms-external, probaly we could create a new branch (say cms/2.0.1) and make the change in that branch,
waht do you think?

[smuzaffar]

@alberto-sanchez , the usual procedure for such fixes is that

• fork the cms-external repo e.g in this case https://github.com/cms-externals/evtgen
• Add changes in your fork on top of the branch e.g. in this case add your changes for cms/2.0.0 branch
• Open a PR using your feature/bugfix branch to the https://github.com/cms-externals/evtgen

Once we have PR for https://github.com/cms-externals/evtgen then we can already start testing it

[smuzaffar]

by the way, you can do the same for cms/1.6.0 branch (i.e instead of adding patch in to cmsdist, it is better to patch it directly in the cms-externals/evtgen repo cms/1.6.0 branch)

[alberto-sanchez]

I have create the Pull request for 2.0, in 1.6 the way the source is downloaded is different, we actually are not using the cms repo, but the tarball distributed at that time.

[smuzaffar]

+externals

I have create the Pull request for 2.0, in 1.6 the way the source is downloaded is different, we actually are not using the cms repo, but the tarball distributed at that time.

ah you are right @alberto-sanchez. This PR is good for 10.6.X then.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1