Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost - update to 1.75.0 #6655

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Feb 16, 2021

changes for Arm are (hopefully) not necessary
(standard_wide doesn't have the strict_ischar)
Resolve #6653

changes for Arm are (hopefully) not necessary
(standard_wide doesn't have the strict_ischar)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_3_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

please test

@mrodozov
Copy link
Contributor Author

mrodozov commented Feb 16, 2021

Resolve #6653

@smuzaffar
Copy link
Contributor

Resolve #6653

I think this comment should go in the PR description in order to github to recognize it

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2066ea/12931/summary.html
COMMIT: cd1bc23
CMSSW: CMSSW_11_3_X_2021-02-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6655/12931/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-16-1100/src/CondFormats/EcalObjects/src/EcalSRSettings.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-16-1100/src/CondFormats/EcalObjects/src/EcalSampleMask.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-16-1100/src/CondFormats/EcalObjects/src/EcalSamplesCorrelation.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-16-1100/src/CondFormats/EcalObjects/src/EcalSimPulseShape.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-16-1100/src/CondFormats/EcalObjects/src/EcalMustacheSCParameters.cc: In member function 'const EcalMustacheSCParameters::ParabolaParameters* EcalMustacheSCParameters::parabolaParameters(float, float) const':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-16-1100/src/CondFormats/EcalObjects/src/EcalMustacheSCParameters.cc:14:32: error: no matching function for call to 'lower_bound(std::vector::const_iterator, std::vector::const_iterator, float&, EcalMustacheSCParameters::parabolaParameters(float, float) const::)'
   14 |                               });
      |                                ^
In file included from /cvmfs/cms-ib.cern.ch/nweek-02668/slc7_amd64_gcc900/external/gcc/9.3.0/include/c++/9.3.0/bits/char_traits.h:39,
                 from /cvmfs/cms-ib.cern.ch/nweek-02668/slc7_amd64_gcc900/external/gcc/9.3.0/include/c++/9.3.0/ios:40,
                 from /cvmfs/cms-ib.cern.ch/nweek-02668/slc7_amd64_gcc900/external/gcc/9.3.0/include/c++/9.3.0/ostream:38,


@smuzaffar
Copy link
Contributor

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2066ea/12936/summary.html
COMMIT: cd1bc23
CMSSW: CMSSW_11_3_X_2021-02-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6655/12936/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-16-1100/src/CondFormats/EcalObjects/src/EcalPulseSymmCovariances.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-16-1100/src/CondFormats/EcalObjects/src/EcalSCDynamicDPhiParameters.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-16-1100/src/CondFormats/EcalObjects/src/EcalSRSettings.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-16-1100/src/CondFormats/EcalObjects/src/EcalSampleMask.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-16-1100/src/CondFormats/EcalObjects/src/EcalMustacheSCParameters.cc: In member function 'const EcalMustacheSCParameters::ParabolaParameters* EcalMustacheSCParameters::parabolaParameters(float, float) const':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-16-1100/src/CondFormats/EcalObjects/src/EcalMustacheSCParameters.cc:14:32: error: no matching function for call to 'lower_bound(std::vector::const_iterator, std::vector::const_iterator, float&, EcalMustacheSCParameters::parabolaParameters(float, float) const::)'
   14 |                               });
      |                                ^
In file included from /cvmfs/cms-ib.cern.ch/nweek-02668/slc7_amd64_gcc900/external/gcc/9.3.0/include/c++/9.3.0/bits/char_traits.h:39,
                 from /cvmfs/cms-ib.cern.ch/nweek-02668/slc7_amd64_gcc900/external/gcc/9.3.0/include/c++/9.3.0/ios:40,
                 from /cvmfs/cms-ib.cern.ch/nweek-02668/slc7_amd64_gcc900/external/gcc/9.3.0/include/c++/9.3.0/ostream:38,


@mrodozov
Copy link
Contributor Author

please test with cms-sw/cmssw#32943

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build HeaderConsistency ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2066ea/12963/summary.html
COMMIT: cd1bc23
CMSSW: CMSSW_11_3_X_2021-02-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6655/12963/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-17-1100/src/CondTools/RPC/plugins/RPCInverseTwinMuxLinkMapESProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-17-1100/src/CondTools/RPC/plugins/RPCLBLinkMapPopConAnalyzer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-17-1100/src/CondTools/RPC/plugins/RPCUXC.cc
>> Building  edm plugin tmp/slc7_amd64_gcc900/src/CondTools/RPC/plugins/CondToolsRPCP/libCondToolsRPCP.so
/cvmfs/cms-ib.cern.ch/nweek-02668/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCondToolsRPC
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc900/src/CondTools/RPC/plugins/CondToolsRPCP/libCondToolsRPCP.so] Error 1
Leaving library rule at src/CondTools/RPC/plugins
Entering library rule at CondTools/RPC
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-17-1100/src/CondTools/RPC/src/L1RPCHwConfigDBWriter.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-17-1100/src/CondTools/RPC/src/L1RPCHwConfigSourceHandler.cc


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-17-1100/src/CaloOnlineTools/HcalOnlineDb/src/WriteL1TriggerObjectsTxt.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-17-1100/src/CaloOnlineTools/HcalOnlineDb/src/XMLLUTLoader.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-17-1100/src/CaloOnlineTools/HcalOnlineDb/src/ZdcLut.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-17-1100/src/CaloOnlineTools/HcalOnlineDb/src/xdaq_compat.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-17-1100/src/CaloOnlineTools/HcalOnlineDb/src/LMap.cc:21:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-17-1100/src/CaloOnlineTools/HcalOnlineDb/interface/LMap.h:77:8: error: no template named 'shared_ptr' in namespace 'std'
  std::shared_ptr p_impl;
  ~~~~~^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-17-1100/src/CaloOnlineTools/HcalOnlineDb/interface/LMap.h:135:8: error: no template named 'shared_ptr' in namespace 'std'
  std::shared_ptr _lmap;
  ~~~~~^


@mrodozov
Copy link
Contributor Author

please test with cms-sw/cmssw#32943

@mrodozov
Copy link
Contributor Author

@slava77 I'd like to ask for a reco diffs check

@slava77
Copy link
Contributor

slava77 commented Feb 21, 2021

@slava77 I'd like to ask for a reco diffs check

In the summary:https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_3_X_2021-02-18-1100+2066ea/41304/validateJR.html

  • all_OldVSNew_RunHI2018wf140p56 | 4
    • this is due to something in the baseline that made some module run for a long time and trigger an ExcessiveTime warning. I think that this can be ignored.
  • all_OldVSNew_TTbar13nanoEDM106Xv1in2017wf1325p81 | 1

@mrodozov
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_3_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 22, 2021

test parameters:

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2066ea/13011/summary.html
COMMIT: cd1bc23
CMSSW: CMSSW_11_3_X_2021-02-21-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6655/13011/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2969 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 75034
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2675926
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

please test for CMSSW_11_3_CLANG_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2066ea/13044/summary.html
COMMIT: cd1bc23
CMSSW: CMSSW_11_3_CLANG_X_2021-02-22-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6655/13044/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4256 lines to the logs
  • Reco comparison results: 18615 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 84726
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 2666229
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.012 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 136.793 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 136.874 ): 0.016 KiB JetMET/SUSYDQM
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2066ea/13043/summary.html
COMMIT: cd1bc23
CMSSW: CMSSW_11_3_X_2021-02-22-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6655/13043/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2956 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 73889
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2677072
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@silviodonato
Copy link
Contributor

+1
the differences seems related to cms-sw/cmssw#32963

@cmsbuild cmsbuild merged commit d6c4fcd into IB/CMSSW_11_3_X/master Mar 2, 2021
@smuzaffar smuzaffar deleted the update-boost-175 branch March 10, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boost 1.75
5 participants