ROOT 6.22 - test TBB 2021.1.1 #6570

mrodozov · 2021-01-20T10:57:05Z

No description provided.

cmsbuild · 2021-01-20T10:57:23Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_3_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

mrodozov · 2021-01-20T11:01:04Z

please test with cms-sw/root#149, #6544, cms-externals/heppdt#1

smuzaffar · 2021-01-20T11:04:39Z

will dd4hep work without toolfile change?

smuzaffar · 2021-01-20T11:05:47Z

cms-externals/heppdt#1 has been merged and is part of IBs, so no need to include it in tests

mrodozov · 2021-01-20T11:13:59Z

yes, because we don't add the flag -DDD4HEP_USE_GEANT4_UNITS=ON to the dd4 cmake here, but only in the dd4hep update. I'm avoiding it on purpose because we are not merging this PR and we'll get the dd4 update before that (I guess). In the next PR I expect we'll already have the dd4 changes.

cms-externals/heppdt#1 has been merged and is part of IBs, so no need to include it in tests

I missed it was also added to cmsdist.

xvallspl · 2021-01-20T13:44:26Z

I've seen the mistake, tricky backports :)

cmsbuild · 2021-01-20T14:56:26Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3b50f/12375/summary.html
COMMIT: e356c6c
CMSSW: CMSSW_11_3_X_2021-01-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6570/12375/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-19-2300/src/FWCore/Concurrency/src/ThreadsController.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-19-2300/src/FWCore/Concurrency/src/WaitingTaskList.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-19-2300/src/FWCore/Concurrency/src/WaitingTaskWithArenaHolder.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-19-2300/src/FWCore/Concurrency/src/setNThreads.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-19-2300/src/FWCore/Concurrency/src/SerialTaskQueue.cc:17:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-19-2300/src/FWCore/Concurrency/interface/SerialTaskQueue.h:134:39: error: expected class-name before '{' token
  134 |     class TaskBase : public tbb::task {
      |                                       ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-19-2300/src/FWCore/Concurrency/interface/SerialTaskQueue.h:166:22: error: 'tbb::empty_task' has not been declared
  166 |     void pushAndWait(tbb::empty_task* iWait, TaskBase*);
      |                      ^~~

xvallspl · 2021-01-20T15:40:55Z

A mistake slipped through, can I request for the build to start again with the updated changes in my branch? I'll hold on merging the patches

smuzaffar · 2021-01-20T15:43:44Z

please test with cms-sw/root#149, #6544

smuzaffar · 2021-01-20T15:44:08Z

@xvallspl , I have re-started the tests

xvallspl · 2021-01-20T15:46:07Z

Thanks, Shahzad!

cmsbuild · 2021-01-20T17:18:53Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3b50f/12389/summary.html
COMMIT: e356c6c
CMSSW: CMSSW_11_3_X_2021-01-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6570/12389/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

make[2]: Leaving directory `/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/rivet/3.1.3-323bd133c547eeec612112f01117e904/rivet-3.1.3/analyses'
make[2]: Leaving directory `/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/rivet/3.1.3-323bd133c547eeec612112f01117e904/rivet-3.1.3/analyses'
make[2]: Leaving directory `/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/rivet/3.1.3-323bd133c547eeec612112f01117e904/rivet-3.1.3/analyses'
make[1]: Leaving directory `/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/rivet/3.1.3-323bd133c547eeec612112f01117e904/rivet-3.1.3/analyses'
make: *** [all-recursive] Error 1
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Z7I6VL (%build)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope
Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Z7I6VL (%build)

smuzaffar · 2021-01-20T17:36:05Z

please test with cms-sw/root#149, #6544
strange error, lets retry

cmsbuild · 2021-01-20T19:10:22Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3b50f/12394/summary.html
COMMIT: e356c6c
CMSSW: CMSSW_11_3_X_2021-01-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6570/12394/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

make[2]: Leaving directory `/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/rivet/3.1.3-c5b4e426ab026fb3075feb506ffa0727/rivet-3.1.3/analyses'
make[2]: Leaving directory `/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/rivet/3.1.3-c5b4e426ab026fb3075feb506ffa0727/rivet-3.1.3/analyses'
make[2]: Leaving directory `/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/rivet/3.1.3-c5b4e426ab026fb3075feb506ffa0727/rivet-3.1.3/analyses'
make[1]: Leaving directory `/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/rivet/3.1.3-c5b4e426ab026fb3075feb506ffa0727/rivet-3.1.3/analyses'
make: *** [all-recursive] Error 1
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.NR6gJs (%build)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope
Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.NR6gJs (%build)

smuzaffar · 2021-01-28T06:09:32Z

@mrodozov , please open a separate PR for rivet changes

mrodozov · 2021-01-28T06:55:11Z

sure, but also this failure I think it's this:
https://github.com/root-project/root/blob/289c1d701d8d36cecd8376f03ffc9651644dd315/core/imt/src/RTaskArena.cxx#L82
and I don't see why a warning would fail

makortel · 2021-01-28T13:29:34Z

and I don't see why a warning would fail

We convert many ROOT messages to exceptions. The default behavior for an "unknown" message is to throw an exception, and some "known" messages are converted to MessageLogger messages with various severity levels. The logic is here
https://github.com/cms-sw/cmssw/blob/master/FWCore/Services/plugins/InitRootHandlers.cc#L178

For these particular messages from RTaskArena
https://github.com/root-project/root/blob/98ff53015fbf7927c0942d331877022c1e5664c8/core/imt/src/RTaskArena.cxx#L77-L84
I'd be tempted to translate them to INFO level in CMSSW (we deliberately want this behavior to occur, and the warning could just confuse users). @Dr15Jones, what do you think?

Dr15Jones · 2021-01-28T14:06:17Z

Let’s first ask the ROOT team exactly why they put that message out. If it is just INFO, we should just do the suggested conversion to a MessageLogger messages.

Dr15Jones · 2021-01-28T14:13:52Z

So I took a look at the code where the message originates
https://github.com/root-project/root/blob/289c1d701d8d36cecd8376f03ffc9651644dd315/core/imt/src/RTaskArena.cxx#L81-L84

and I'm now of the opinion that we should make all messages from "RTaskArenaWrapper" to be MessageLogger INFO messages.

smuzaffar · 2021-02-01T10:53:09Z

do we already have a cmssw PR to convert RTaskArenaWrapper warnings to MessageLogger INFO message?

mrodozov · 2021-02-01T11:00:14Z

not yet, I'm banging head with the data tag job :/

Dr15Jones · 2021-02-01T15:04:34Z

do we already have a cmssw PR to convert RTaskArenaWrapper warnings to MessageLogger INFO message?

If it would help, I can make one.

smuzaffar · 2021-02-01T15:57:29Z

yes please Dr15Jones

If it would help, I can make one.

Dr15Jones · 2021-02-01T16:12:34Z

See cms-sw/cmssw#32782

smuzaffar · 2021-02-01T16:38:19Z

please test with cms-sw/cmssw#32782

mrodozov · 2021-02-01T21:06:20Z

CERN network is having trouble -> requests to github are failing with timeouts, see:
https://cern.service-now.com/service-portal/?id=outage&n=OTG0061899

cmsbuild · 2021-02-02T05:07:54Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3b50f/12629/summary.html
COMMIT: e7ea71f
CMSSW: CMSSW_11_3_X_2021-02-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6570/12629/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestCalibrationLumiAlCaRecoProducers had ERRORS
---> test test_PixelBaryCentreTool had ERRORS
---> test CalibCalorimetryEcalLaserSortingRunStreamer had ERRORS
---> test testAlignmentOfflineValidation had ERRORS
and more ...

RelVals

4.53

----- Begin Fatal Exception 02-Feb-2021 05:48:42 CET-----------------------
An exception of category 'FileReadError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   Additional Info:
      [a] Fatal Root Error: @SUB=TThreadExecutor::ParallelFor
tbb::global_control is limiting the number of parallel workers. Proceeding with 1 threads this time

----- End Fatal Exception -------------------------------------------------

136.731

----- Begin Fatal Exception 02-Feb-2021 05:48:42 CET-----------------------
An exception of category 'FileReadError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   Additional Info:
      [a] Fatal Root Error: @SUB=TThreadExecutor::ParallelFor
tbb::global_control is limiting the number of parallel workers. Proceeding with 1 threads this time

----- End Fatal Exception -------------------------------------------------

136.874

----- Begin Fatal Exception 02-Feb-2021 05:48:44 CET-----------------------
An exception of category 'FileReadError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   Additional Info:
      [a] Fatal Root Error: @SUB=TThreadExecutor::ParallelFor
tbb::global_control is limiting the number of parallel workers. Proceeding with 1 threads this time

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.424.42_RunMET2012A+RunMET2012A+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunMET2012A+RunMET2012A+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log
4.414.41_RunTau2012A+RunTau2012A+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunTau2012A+RunTau2012A+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log
4.44.4_RunMinBias2012A+RunMinBias2012A+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunMinBias2012A+RunMinBias2012A+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

Expand to see more relval errors ...

AddOn Tests

fastsim

----- Begin Fatal Exception 02-Feb-2021 05:53:25 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
   Additional Info:
      [a] Another exception was caught while trying to clean up files after the primary fatal exception.
      [b] Another exception was caught while trying to clean up runs after the primary fatal exception.
      [c] Fatal Root Error: @SUB=TThreadExecutor::ParallelFor
tbb::global_control is limiting the number of parallel workers. Proceeding with 4 threads this time

----- End Fatal Exception -------------------------------------------------

pat1

----- Begin Fatal Exception 02-Feb-2021 05:48:32 CET-----------------------
An exception of category 'FileReadError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   Additional Info:
      [a] Fatal Root Error: @SUB=TThreadExecutor::ParallelFor
tbb::global_control is limiting the number of parallel workers. Proceeding with 1 threads this time

----- End Fatal Exception -------------------------------------------------

hlt_data_Fake2

----- Begin Fatal Exception 02-Feb-2021 05:48:29 CET-----------------------
An exception of category 'FileReadError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   Additional Info:
      [a] Fatal Root Error: @SUB=TThreadExecutor::ParallelFor
tbb::global_control is limiting the number of parallel workers. Proceeding with 4 threads this time

----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

smuzaffar · 2021-02-02T17:37:31Z

please test with cms-sw/cmssw#32782

mrodozov · 2021-02-04T07:20:34Z

abort

mrodozov · 2021-02-04T07:20:46Z

please test with cms-sw/cmssw#32782

mrodozov · 2021-02-05T09:31:07Z

rivet patch is merged, we have a PR for the latest DD4Hep and another one for TBB. closing this.
The PR is failing because of the missing DD4Hep module files (might be due to the IB not including the fix, we'll see)

ROOT 6.22 - test TBB 2021.1.1

e356c6c

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Jan 20, 2021

cmsbuild added tests-started and removed tests-pending labels Jan 20, 2021

cmsbuild added tests-rejected and removed tests-started labels Jan 20, 2021

cmsbuild added tests-started and removed tests-rejected labels Jan 20, 2021

cmsbuild added tests-rejected and removed tests-started labels Jan 20, 2021

cmsbuild added tests-started and removed tests-rejected labels Jan 20, 2021

cmsbuild removed the tests-started label Jan 20, 2021

cmsbuild added tests-rejected and removed tests-started labels Jan 28, 2021

cmsbuild added tests-started and removed tests-rejected labels Feb 1, 2021

cmsbuild added tests-rejected and removed tests-started labels Feb 2, 2021

smuzaffar mentioned this pull request Feb 2, 2021

Ignore messages from RTaskArenaWrapper cms-sw/cmssw#32782

Merged

cmsbuild added tests-started and removed tests-rejected labels Feb 2, 2021

cmsbuild added the requires-external label Feb 4, 2021

mrodozov closed this Feb 5, 2021

mrodozov deleted the update-root622-and-dd4hep-for-tbb branch February 5, 2021 14:16

makortel mentioned this pull request Feb 23, 2021

Excess number of "tbb" info message being generated cms-sw/cmssw#32977

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ROOT 6.22 - test TBB 2021.1.1 #6570

ROOT 6.22 - test TBB 2021.1.1 #6570

mrodozov commented Jan 20, 2021

cmsbuild commented Jan 20, 2021

mrodozov commented Jan 20, 2021

smuzaffar commented Jan 20, 2021

smuzaffar commented Jan 20, 2021

mrodozov commented Jan 20, 2021

xvallspl commented Jan 20, 2021

cmsbuild commented Jan 20, 2021

xvallspl commented Jan 20, 2021 •

edited

Loading

smuzaffar commented Jan 20, 2021

smuzaffar commented Jan 20, 2021

xvallspl commented Jan 20, 2021

cmsbuild commented Jan 20, 2021

smuzaffar commented Jan 20, 2021

cmsbuild commented Jan 20, 2021

smuzaffar commented Jan 28, 2021

mrodozov commented Jan 28, 2021

makortel commented Jan 28, 2021

Dr15Jones commented Jan 28, 2021

Dr15Jones commented Jan 28, 2021

smuzaffar commented Feb 1, 2021

mrodozov commented Feb 1, 2021

Dr15Jones commented Feb 1, 2021

smuzaffar commented Feb 1, 2021

Dr15Jones commented Feb 1, 2021

smuzaffar commented Feb 1, 2021

mrodozov commented Feb 1, 2021

cmsbuild commented Feb 2, 2021

smuzaffar commented Feb 2, 2021

mrodozov commented Feb 4, 2021

mrodozov commented Feb 4, 2021

mrodozov commented Feb 5, 2021

ROOT 6.22 - test TBB 2021.1.1 #6570

ROOT 6.22 - test TBB 2021.1.1 #6570

Conversation

mrodozov commented Jan 20, 2021

cmsbuild commented Jan 20, 2021

mrodozov commented Jan 20, 2021

smuzaffar commented Jan 20, 2021

smuzaffar commented Jan 20, 2021

mrodozov commented Jan 20, 2021

xvallspl commented Jan 20, 2021

cmsbuild commented Jan 20, 2021

Build

xvallspl commented Jan 20, 2021 • edited Loading

smuzaffar commented Jan 20, 2021

smuzaffar commented Jan 20, 2021

xvallspl commented Jan 20, 2021

cmsbuild commented Jan 20, 2021

External Build

smuzaffar commented Jan 20, 2021

cmsbuild commented Jan 20, 2021

External Build

smuzaffar commented Jan 28, 2021

mrodozov commented Jan 28, 2021

makortel commented Jan 28, 2021

Dr15Jones commented Jan 28, 2021

Dr15Jones commented Jan 28, 2021

smuzaffar commented Feb 1, 2021

mrodozov commented Feb 1, 2021

Dr15Jones commented Feb 1, 2021

smuzaffar commented Feb 1, 2021

Dr15Jones commented Feb 1, 2021

smuzaffar commented Feb 1, 2021

mrodozov commented Feb 1, 2021

cmsbuild commented Feb 2, 2021

Unit Tests

RelVals

RelVals-INPUT

AddOn Tests

smuzaffar commented Feb 2, 2021

mrodozov commented Feb 4, 2021

mrodozov commented Feb 4, 2021

mrodozov commented Feb 5, 2021

xvallspl commented Jan 20, 2021 •

edited

Loading