Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dasgoclient version #6343

Merged
merged 1 commit into from
Oct 28, 2020
Merged

New dasgoclient version #6343

merged 1 commit into from
Oct 28, 2020

Conversation

vkuznet
Copy link
Contributor

@vkuznet vkuznet commented Oct 27, 2020

This version removes Phedex data service from DAS queries.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vkuznet (Valentin Kuznetsov) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 27, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: bbea16c

CMSSW: CMSSW_11_2_X_2020-10-27-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-815783/10334/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Wed Oct 28 01:24:59 2020-date Wed Oct 28 01:17:41 2020 s - exit: 35584

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-815783/10334/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544092
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544069
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@vkuznet
Copy link
Contributor Author

vkuznet commented Oct 28, 2020

@smuzaffar , I'm not sure that this change is caused the failure in some of the tests. According to log https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-815783/10334/addOnTests/logs/cmsDriver-fastsim_cmsDriver.py_TTbar_8TeV_TuneCUETP8M1_cfi__--conditions_auto:run1_mc_--fast__-n_100_--eventcontent_AODSIM,DQM_--relval_100000,1000_-s_GEN,SIM,RECOBEFMI.log
there is a traceback from some of the CMSSW module(s) and I don't see anything related to dasgoclient changes.

@makortel
Copy link
Contributor

@vkuznet Seems to be a random crash in that particular test (cms-sw/cmssw#24051).

@smuzaffar
Copy link
Contributor

smuzaffar commented Oct 28, 2020

for now, we need to merge this only for DEVEL IBs to test new dasgoclient. I will backport it for normal IBs once we have successfully tested it for a week in DEVEL

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Oct 28, 2020
@smuzaffar smuzaffar changed the base branch from IB/CMSSW_11_2_X/master to IB/CMSSW_11_2_X/devel October 28, 2020 18:47
@smuzaffar
Copy link
Contributor

lets merge it for devel IB. If every thing goes fine for DEVEL IBs then on Wednesday 4th NOV we can backport it to normal IBs.

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 6e01685 into cms-sw:IB/CMSSW_11_2_X/devel Oct 28, 2020
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/devel IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

backport done
Successfully backported PR #6343 as #6375 for branch IB/CMSSW_11_2_X/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants