Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX runtime] Update for powerpc #5743

Merged
merged 6 commits into from
Apr 27, 2020

Conversation

mrodozov
Copy link
Contributor

please test
patch is taken from here onnx/onnx#2482

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 14, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5690/console Started: 2020/04/14 17:53

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

@mrodozov , I think we need cmssw PR too to go with protobuf.

@cmsbuild
Copy link
Contributor

-1

Tested at: 675cbe1

  • Build:

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/nweek-02624/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: onnx/libonnx_proto.a(onnx-ml.pb.cc.o):(.data.rel.ro._ZTVN4onnx13FunctionProtoE[_ZTVN4onnx13FunctionProtoE]+0x20): undefined reference to `google::protobuf::Message::GetTypeName[abi:cxx11]() const'
/cvmfs/cms-ib.cern.ch/nweek-02624/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: onnx/libonnx_proto.a(onnx-ml.pb.cc.o):(.data.rel.ro._ZTVN4onnx13FunctionProtoE[_ZTVN4onnx13FunctionProtoE]+0x58): undefined reference to `google::protobuf::Message::InitializationErrorString[abi:cxx11]() const'
/cvmfs/cms-ib.cern.ch/nweek-02624/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: onnx/libonnx_proto.a(onnx-ml.pb.cc.o):(.data.rel.ro._ZTVN4onnx13FunctionProtoE[_ZTVN4onnx13FunctionProtoE]+0x60): undefined reference to `google::protobuf::Message::CheckTypeAndMergeFrom(google::protobuf::MessageLite const&)'
/cvmfs/cms-ib.cern.ch/nweek-02624/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: onnx/libonnx_proto.a(onnx-ml.pb.cc.o):(.data.rel.ro._ZTVN4onnx13FunctionProtoE[_ZTVN4onnx13FunctionProtoE]+0xa0): undefined reference to `google::protobuf::Message::DiscardUnknownFields()'
/cvmfs/cms-ib.cern.ch/nweek-02624/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: onnx/libonnx_proto.a(onnx-ml.pb.cc.o):(.data.rel.ro._ZTVN4onnx13FunctionProtoE[_ZTVN4onnx13FunctionProtoE]+0xa8): undefined reference to `google::protobuf::Message::SpaceUsedLong() const'
collect2: error: ld returned 1 exit status
[650/660] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/c++  -DEIGEN_MPL2_ONLY -DPLATFORM_POSIX -DUSE_EIGEN_FOR_BLAS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/onnxruntime/1.0.0-3f990d/onnxruntime-1.0.0/include/onnxruntime -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/onnxruntime/1.0.0-3f990d/onnxruntime-1.0.0/include/onnxruntime/core/session -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/protobuf/3.11.4-3f990d/include -Ionnx/.. -I. -Ionnx -Dgsl_CONFIG_CONTRACT_VIOLATION_THROWS -Wall -Wextra -ffunction-sections -fdata-sections -Wno-parentheses -O3 -DNDEBUG -DGSL_UNENFORCED_ON_CONTRACT_VIOLATION -fPIC   -Wno-unused-parameter -Wno-unused-variable -Wno-unused-but-set-variable -std=gnu++14 -MD -MT CMakeFiles/onnx_test_data_proto.dir/tml.pb.cc.o -MF CMakeFiles/onnx_test_data_proto.dir/tml.pb.cc.o.d -o CMakeFiles/onnx_test_data_proto.dir/tml.pb.cc.o -c tml.pb.cc
ninja: build stopped: subcommand failed.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.3h2p3E (%build)




You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f990d/5690/summary.html

@cmsbuild
Copy link
Contributor

Pull request #5743 was updated.

@mrodozov
Copy link
Contributor Author

please test
I'll fix the cmssw part, but lets see the external built
protobuf builds with cmake now. the installation is the same except it has a cmake config in /lib

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5704/console Started: 2020/04/15 17:50

@mrodozov
Copy link
Contributor Author

abort

@mrodozov
Copy link
Contributor Author

mrodozov commented Apr 15, 2020

test parameters:

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29486

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-325b32/5850/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696114
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29486
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: ae3d561
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-325b32/5860/summary.html
CMSSW: CMSSW_11_1_X_2020-04-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-325b32/5860/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696114
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants