Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCC 8.4] Update GCC to 8.4.0 #5704

Merged
merged 4 commits into from
May 7, 2020
Merged

[GCC 8.4] Update GCC to 8.4.0 #5704

merged 4 commits into from
May 7, 2020

Conversation

mrodozov
Copy link
Contributor

the recipe builds (at least)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

@mrodozov , can you plese check if any of these
https://github.com/cms-sw/cmsdist/pull/5704/files#diff-a9cd42e7697d89896582fdc58f96b627L18-L22
need updates?

@smuzaffar
Copy link
Contributor

try updaing these versions
https://formulae.brew.sh/formula/gcc@8

@cmsbuild
Copy link
Contributor

Pull request #5704 was updated.

@smuzaffar
Copy link
Contributor

I see you have updated gmp, can you update the gmp-static.spec too? Pls check if we are using gmp.spec or not ? Do we have any other external spec which should be updated?

@smuzaffar
Copy link
Contributor

same for gcc9 branch

@mrodozov
Copy link
Contributor Author

both 8.4 and 9.3 built. three tools can be updated but also require further digging islVersion to 0.22 binutilsVersion to 2.34 and elfutilsVersion to 0.179

@cmsbuild
Copy link
Contributor

Pull request #5704 was updated.

gmp.spec Outdated
@@ -1,2 +1,2 @@
### RPM external gmp 6.1.2
Source: ftp://mirrors.kernel.org/gnu/%n/%n-%realversion.tar.xz
### RPM external gmp 6.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have any thing using this? I mean any package depends on gmp or all of our packages use gmp-static?

Copy link
Contributor Author

@mrodozov mrodozov Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only in this file:
cmssw-queue-override.file

%if "%(case %realversion in (*_ICC_X*) echo true ;; (*) echo false ;; esac)" == "true"                                                                                    
%define gitcommit       %(echo %realversion | sed -e 's|_ICC_X|_X|')                                                                                                      
%define scram_compiler  icc                                                                                                                                               
%define extra_tools     mpfr gmp icc-cxxcompiler icc-f77compiler icc-ccompiler                                                                                            
%endif 

icc is using it somehow
also there is elfutils.spec not used by anything.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gmp tool is defined in gmp-static ( https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_1_X/master/gmp-static-toolfile.spec ) , so I think no one is using gmp.spec. So better to delete it.

@cmsbuild
Copy link
Contributor

Pull request #5704 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5464/console Started: 2020/03/31 18:29

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

-1

Tested at: 8dbe702

CMSSW: CMSSW_11_1_X_2020-03-31-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9ab4a/5464/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test test_StorageFactory_Http had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9ab4a/5464/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 118 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692110
  • DQMHistoTests: Total failures: 454
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2691337
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

please test
refresh the test results

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+1
Tested at: 8dbe702
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9ab4a/5973/summary.html
CMSSW: CMSSW_11_1_X_2020-05-04-1100
SCRAM_ARCH: slc7_amd64_gcc820
Additional comment: 'Compilation

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9ab4a/5973/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 60 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 774
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695146
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

+1
I merged cms-sw/cmssw#29738
@smuzaffar feel free to merge this when you prefer.
Sorry for being so late!

@smuzaffar
Copy link
Contributor

thanks @silviodonato . As I wrote to you privately , let wait for 23h00 IB reuslts (with cmssw changes only), Tomorrow morning I will merge GCC and force build an IB (I will make sure tag cmsdist before merging gcc).

@smuzaffar
Copy link
Contributor

+externals
GCC 8.4 was merged in DEVEL IBs for full scale testing. DEVEL IBs looks good and we are ready to include this for normal IBs now. So that we can get GCC 8.4 in 11.1.0.pre7. A cmsdist tag IB/CMSSW_11_1_X/master/GCC83 has been created to point to the cmsdist without this update.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 08b6460 into IB/CMSSW_11_1_X/master May 7, 2020
@smuzaffar smuzaffar deleted the gcc84 branch May 9, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants