-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCC 8.4] Update GCC to 8.4.0 #5704
Conversation
@mrodozov , can you plese check if any of these |
try updaing these versions |
Pull request #5704 was updated. |
I see you have updated gmp, can you update the gmp-static.spec too? Pls check if we are using gmp.spec or not ? Do we have any other external spec which should be updated? |
same for gcc9 branch |
both 8.4 and 9.3 built. three tools can be updated but also require further digging islVersion to 0.22 binutilsVersion to 2.34 and elfutilsVersion to 0.179 |
Pull request #5704 was updated. |
gmp.spec
Outdated
@@ -1,2 +1,2 @@ | |||
### RPM external gmp 6.1.2 | |||
Source: ftp://mirrors.kernel.org/gnu/%n/%n-%realversion.tar.xz | |||
### RPM external gmp 6.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have any thing using this? I mean any package depends on gmp or all of our packages use gmp-static?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only in this file:
cmssw-queue-override.file
%if "%(case %realversion in (*_ICC_X*) echo true ;; (*) echo false ;; esac)" == "true"
%define gitcommit %(echo %realversion | sed -e 's|_ICC_X|_X|')
%define scram_compiler icc
%define extra_tools mpfr gmp icc-cxxcompiler icc-f77compiler icc-ccompiler
%endif
icc is using it somehow
also there is elfutils.spec not used by anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this gmp
tool is defined in gmp-static ( https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_1_X/master/gmp-static-toolfile.spec ) , so I think no one is using gmp.spec. So better to delete it.
Pull request #5704 was updated. |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 8dbe702 CMSSW: CMSSW_11_1_X_2020-03-31-1100 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test test_StorageFactory_Http had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
thanks @silviodonato . As I wrote to you privately , let wait for 23h00 IB reuslts (with cmssw changes only), Tomorrow morning I will merge GCC and force build an IB (I will make sure tag cmsdist before merging gcc). |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will be automatically merged. |
the recipe builds (at least)