Revert "Enable Condformats C++ modules" #5691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_1_X/rootmodule. @cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks. |
|
I guess there is no need to test it, it can be merged and full IB will show us if this fixed any thing. |
|
Yea. I will merge once we finish discussing separately The plan
On 23 Mar 2020, at 19:46, Malik Shahzad Muzaffar <[email protected]> wrote:
I guess there is no need to test it, it can be merged and full IB will show us if this fixed any thing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#5691 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ62WGRBJU32563NTEDRI6U5PANCNFSM4LSBLE6A>.
|
|
merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5600
we have some new errors in the modules IB - as we changed both this and ROOT at the same time, we want to revert this PR to find out which is the cause.