Include the CUDA Profiling Tools Interface (CUPTI) #5512
Conversation
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
@smuzaffar could you include this in the next IBs ? |
|
Comparison is ready Comparison Summary:
|
| <info url="https://docs.nvidia.com/cupti/Cupti/index.html"/> | ||
| <lib name="nvperf_host"/> | ||
| <lib name="nvperf_target"/> | ||
| </tool> |
There was a problem hiding this comment.
@fwyzard do we need these new tools? A tool with out INCLUDE and LIBDIR directory is of no use. If someone adds a dependency in BuildFile then scram does not know what should be -L/path for these libs.
There was a problem hiding this comment.
the include and libdir should be the same as cuda; should I add them explicitly ?
There was a problem hiding this comment.
did you check if these libs are linked against libcuda.so? if then then just add dependency on cuda otherwise I would suggest to add a new cuda_interface tool file e.g. something like [a] and depend on it
[a]
cat << \EOF_TOOLFILE >%{i}/etc/scram.d/cuda_intrface.xml
<tool name="cuda_interface" version="@TOOL_VERSION@">
<info url="https://docs.nvidia.com/cuda/index.html"/>
<client>
<environment name="CUDA_INTERFACE_BASE" default="@TOOL_ROOT@"/>
<environment name="LIBDIR" default="$CUDA_INTERFACE_BASE/lib64/stubs"/>
<environment name="INCLUDE" default="$CUDA_INTERFACE_BASE/include"/>
</client>
<flags SKIP_TOOL_SYMLINKS="1"/>
</tool>
EOF_TOOLFILE
There was a problem hiding this comment.
No, according to the output of ldd the new libraries do not depend on other cuda libraries.
For the moment I'll just add the include and lib64 explicitly, we can revise it once we understand a bit better the dependencies.
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #5512 was updated. |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@smuzaffar can you merge this ? |
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@silviodonato could you approve this for the coming IBs ? |
|
merging it as this looks good and it just adds new tools, so should not break any thing. |
No description provided.