Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CXXMODULE] Updated root to tip of branch master #5454

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4140/console Started: 2020/01/06 12:54
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4141/console Started: 2020/01/06 14:44
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4144/console Started: 2020/01/06 15:25

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_1_X/rootmodule.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

-1

Tested at: 7d573ea

  • Build:

I found compilation warning when building: See details on the summary page.

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734139/4140/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

-1

Tested at: 7d573ea

  • Build:

I found compilation warning when building: See details on the summary page.

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734139/4141/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

Pull request #5454 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

-1

Tested at: b26cfed

CMSSW: CMSSW_11_1_CXXMODULE_X_2020-01-02-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734139/4144/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation warning when building: See details on the summary page.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@smuzaffar
Copy link
Contributor Author

we get the same build errors as we have in IBs. merging it to move cxxmodules ibs to pick up latest root changes

@smuzaffar smuzaffar merged commit d976e95 into IB/CMSSW_11_1_X/rootmodule Jan 7, 2020
@smuzaffar smuzaffar deleted the smuzaffar-patch-2 branch January 8, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants