New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hydjet integration as external #5412

Merged

cmsbuild merged 14 commits into cms-sw:IB/CMSSW_11_2_X/master from wouf:patch-6

Jul 22, 2020

Contributor

wouf commented Dec 6, 2019 •

edited by silviodonato

Loading

Hydjet 1.9.1 integration as external. Update pyquen.

PR cmssw: cms-sw/cmssw#30185

wouf added 5 commits

December 7, 2019 01:09


          Create hydjet.spec

97b8793


          Create hydjet-toolfile.spec

4698a3e


          Update pyquen.spec

7b2cd75


          Merge pull request #3 from wouf/patch-5

250cebb

Create hydjet-toolfile.spec


          Merge pull request #4 from wouf/patch-4

c5a125a

Create hydjet.spec

cmsbuild added comparison-pending externals-pending orp-pending pending-signatures tests-pending labels

Contributor

cmsbuild commented Dec 6, 2019

A new Pull Request was created by @wouf for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

Contributor

smuzaffar commented Dec 6, 2019

assign generators

Contributor

cmsbuild commented Dec 6, 2019

New categories assigned: generators

@alberto-sanchez,@SiewYan,@qliphy,@efeyazgan,@mkirsano,@agrohsje you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild added the generators-pending label

smuzaffar reviewed

View reviewed changes

hydjet.spec Outdated


		Source: http://cern.ch/lokhtin/hydro/%{n}-%{realversion}.tar.gz

		BuildRequires: cmake

Contributor

smuzaffar Dec 6, 2019

please also add build dependency on gmake otherwise it will pick system gmake.

Contributor Author

wouf Dec 7, 2019

Thanks for advice. But, does it matter?

Contributor

smuzaffar Dec 9, 2019

yes it does, some times we end up in env (e.g. docker containers with minimal package installation) where gmake is not available via system

Contributor Author

wouf Dec 9, 2019

I mean does it matter gmake, make, or ninja tool is used?

Contributor

smuzaffar Dec 9, 2019

it depends, if you have run cmake to use ninja then you need to add dependency on ninja otheriwse default is make (which is available via our gmake.spec) and for that you need to add dependency on gmake.

Contributor Author

wouf Dec 9, 2019

Thank You for Your explanation!

smuzaffar reviewed

View reviewed changes

hydjet.spec Outdated


		%install

		cmake --build . --target install --clean-first -- %{makeprocesses}

Contributor

smuzaffar Dec 6, 2019

please remove --clean-first here otherwise it will clean and re-build

Contributor Author

wouf Dec 7, 2019

Yes, that was the goal (to clean in case the previous build found). What's wrong? The same behaviour was realized for pyquen.

Contributor

smuzaffar Dec 9, 2019 •

edited

Loading

there is no need to do it twice. It has been done in the %build section already

Contributor Author

wouf Dec 9, 2019

I see, thanks!

Contributor

smuzaffar commented Dec 6, 2019

in order to get this in cmssw environment please update cmssw-tool-conf.spec and add dependency on hydjet-toolfile

wouf added 2 commits

December 7, 2019 07:48


          Update cmssw-tool-conf.spec

7134a15


          Merge pull request #5 from wouf/patch-7

399308a

Update cmssw-tool-conf.spec

Contributor

cmsbuild commented Dec 7, 2019

Pull request #5412 was updated.

Contributor Author

wouf commented Dec 7, 2019

Thanks, I added hydjet-toolfile to cmssw-tool-conf.spec in patch-7


          Update pyquen.spec

30ddf90

Contributor

cmsbuild commented Dec 9, 2019

Pull request #5412 was updated.


          Update hydjet.spec

9556f1e

Contributor

cmsbuild commented Dec 9, 2019

Pull request #5412 was updated.


          Update pyquen.spec

44ed6cd

Contributor

cmsbuild commented Dec 9, 2019

Pull request #5412 was updated.


          Update hydjet.spec

2c0d3be

Contributor

cmsbuild commented Dec 9, 2019

Pull request #5412 was updated.

Contributor

smuzaffar commented Dec 10, 2019

please test workflow 300.0

Contributor

cmsbuild commented Jul 21, 2020 •

edited

Loading

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-20-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8166/console Started: 2020/07/21 16:37

cmsbuild added tests-started and removed tests-pending labels

Contributor

cmsbuild commented Jul 21, 2020

+1
Tested at: 301be52
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3701e4/8166/summary.html
CMSSW: CMSSW_11_2_X_2020-07-20-2300
SCRAM_ARCH: slc7_amd64_gcc820

Contributor

cmsbuild commented Jul 21, 2020

Comparison job queued.

cmsbuild added tests-approved and removed tests-started labels

Contributor

cmsbuild commented Jul 21, 2020 •

edited

Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30185

CMSSW_11_2_X_2020-07-21-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8188/console Started: 2020/07/21 19:01

cmsbuild added requires-external tests-started and removed tests-approved labels

Contributor

cmsbuild commented Jul 21, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3701e4/8166/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2525996
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2525943
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 33 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
Checked 144 log files, 17 edm output root files, 34 DQM output files

cmsbuild added comparison-available and removed comparison-pending labels

Contributor

cmsbuild commented Jul 21, 2020

+1
Tested at: 301be52
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d1961/8188/summary.html
CMSSW: CMSSW_11_2_X_2020-07-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

Contributor

cmsbuild commented Jul 21, 2020

Comparison job queued.

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels

Contributor

cmsbuild commented Jul 21, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d1961/8188/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 812 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2525996
DQMHistoTests: Total failures: 4181
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2521768
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 144 log files, 17 edm output root files, 34 DQM output files

cmsbuild added comparison-available and removed comparison-pending labels

Contributor

qliphy commented Jul 22, 2020

+1

cmsbuild added generators-approved and removed generators-pending labels

Contributor

silviodonato commented Jul 22, 2020

merge

cmsbuild added orp-approved and removed orp-pending labels

cmsbuild merged commit 08a6cf8 into cms-sw:IB/CMSSW_11_2_X/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comparison-available externals-pending generators-approved orp-approved pending-signatures requires-external tests-approved