Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EgammaAnalysis-ElectronTools] Push the 2018 S+S files #4969

Merged
merged 2 commits into from
May 20, 2019
Merged

[EgammaAnalysis-ElectronTools] Push the 2018 S+S files #4969

merged 2 commits into from
May 20, 2019

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented May 14, 2019 •
edited
Loading

resolves #4951
Note that this just adds couple of new files cms-data/EgammaAnalysis-ElectronTools#7

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

smuzaffar added a commit that referenced this pull request May 14, 2019
@smuzaffar
[10.2.X][EgammaAnalysis-ElectronTools] Push the 2018 S+S files
e77b9d4 
backport of #4969
This was referenced May 14, 2019
Merged
Closed
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2019 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/203/console Started: 2019/05/14 13:41

@cmsbuild
Copy link
Contributor

+1
Tested at: 6e32788
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38790e/203/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38790e/203/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212004
  • DQMHistoTests: Total failures: 131
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211669
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_10_6_X/gcc700 to IB/CMSSW_11_0_X/gcc700 May 15, 2019 10:30
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2019 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/320/console Started: 2019/05/18 08:46

@cmsbuild
Copy link
Contributor

Pull request #4969 was updated.

@cmsbuild
Copy link
Contributor

+1
Tested at: 121b109
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38790e/320/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38790e/320/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211772
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211436
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar
Copy link
Contributor Author

+externals
two new files added

@smuzaffar smuzaffar merged commit 3bb152c into IB/CMSSW_11_0_X/gcc700 May 20, 2019
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

mrodozov added a commit that referenced this pull request May 22, 2019
@mrodozov
[10.6.X][EgammaAnalysis-ElectronTools] Push the 2018 S+S files
e4bb35f 
backport of #4969 on 10.6
@peruzzim
Copy link

There was some issue here, the e4bb35f commit above only updates PhysicsTools-NanoAOD to V01-00-05, and this is not consistent with its comment.
We need to have both PhysicsTools-NanoAOD->V01-00-05 and EgammaAnalysis-ElectronTools->V00-01-04 in 106X for #26845 to work.

@smuzaffar
Copy link
Contributor Author

smuzaffar commented May 22, 2019 •
edited
Loading

@peruzzim , #4996 now updated
PhysicsTools-NanoAOD->V01-00-05
EgammaAnalysis-ElectronTools->V00-01-04

@smuzaffar smuzaffar deleted the smuzaffar-patch-7 branch May 28, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cms-data/EgammaAnalysis-ElectronTools#7: Push the 2018 S+S files
3 participants
@smuzaffar @cmsbuild @peruzzim