Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.5.X][GCC 8] Patch boost to avoid unnecessary parentheses warnings #4623

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

smuzaffar
Copy link
Contributor

back ported boost patch: boostorg/mpl#34

slc7_amd64_gcc820/external/boost/1.67.0-cms/include/boost/mpl/assert.hpp:188:21: warning: unnecessary parentheses in declaration of 'assert_arg' [-Wparentheses]
  failed ************ (Pred::************
                      ^
slc7_amd64_gcc820/external/boost/1.67.0-cms/include/boost/mpl/assert.hpp:193:21: warning: unnecessary parentheses in declaration of 'assert_not_arg' [-Wparentheses]
  failed ************ (boost::mpl::not_<Pred>::************

back ported boost patch: boostorg/mpl#34 
```
slc7_amd64_gcc820/external/boost/1.67.0-cms/include/boost/mpl/assert.hpp:188:21: warning: unnecessary parentheses in declaration of 'assert_arg' [-Wparentheses]
  failed ************ (Pred::************
                      ^
slc7_amd64_gcc820/external/boost/1.67.0-cms/include/boost/mpl/assert.hpp:193:21: warning: unnecessary parentheses in declaration of 'assert_not_arg' [-Wparentheses]
  failed ************ (boost::mpl::not_<Pred>::************
```
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32470/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_5_X/gcc820.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar smuzaffar merged commit c63cd52 into IB/CMSSW_10_5_X/gcc820 Jan 8, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4623/32470/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 38468 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3153717
  • DQMHistoTests: Total failures: 102662
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 3050842
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.216 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 136.731 ): 0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 25202.0 ): 0.063 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 136.85 ): 0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 10224.0 ): 0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 136.788 ): 0.012 KiB JetMET/SUSYDQM
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants