[10.4.X] [ROOT] Cherry-pick changes to resolve memory over-write due to execution of a I/O #4452

smuzaffar · 2018-10-26T12:59:17Z

root-project/root#2861

…rite due to execution of a I/O root-project/root#2861

smuzaffar · 2018-10-26T12:59:26Z

please test

cmsbuild · 2018-10-26T12:59:35Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31292/console

cmsbuild · 2018-10-26T12:59:37Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

cmsbuild · 2018-10-27T02:55:18Z

-1

Tested at: fe76dd5

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4452/31292/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

The relvals timed out after 2 hours.

cmsbuild · 2018-10-27T02:55:20Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

smuzaffar · 2018-10-27T14:10:51Z

please test

cmsbuild · 2018-10-27T14:11:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31320/console

cmsbuild · 2018-10-28T00:50:53Z

+1
Tested at: fe76dd5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4452/31320/summary.html

cmsbuild · 2018-10-28T00:50:56Z

Comparison job queued.

cmsbuild · 2018-10-28T02:21:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4452/31320/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 178 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2994843
DQMHistoTests: Total failures: 15
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2994631
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

smuzaffar · 2018-10-28T07:52:59Z

+externals

cmsbuild · 2018-11-01T19:52:39Z

+1
Tested at: fe76dd5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4452/31414/summary.html

cmsbuild · 2018-11-01T19:52:42Z

Comparison job queued.

cmsbuild · 2018-11-01T21:08:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4452/31414/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 178 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2993155
DQMHistoTests: Total failures: 83
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2992875
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

smuzaffar · 2018-11-15T03:10:37Z

please test

cmsbuild · 2018-11-15T03:10:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31666/console

fabiocos · 2018-11-15T11:42:14Z

@slava77 @perrotta there was any conclusion about these differences? I see that now @smuzaffar is producing again the set of plots for a further test

smuzaffar · 2018-11-15T11:43:59Z

@fabiocos , the previous plots/logs were deleted that is why I am re-running.

slava77 · 2018-11-15T13:00:47Z

I didn't find time to make a local root build for further investigation.
it would be nice to get something scram-able centrally.

smuzaffar · 2018-11-15T13:27:11Z

we can merge it for DEVEL IBs so that you can test there

slava77 · 2018-11-15T13:47:54Z

we can merge it for DEVEL IBs so that you can test there

sure, as long as it's the same 6.12 version in the DEVEL to compare with in the baseline as we have in the current 104X [just in case more may be already going on in the DEVEL which can affect this check/test]

smuzaffar · 2018-11-15T13:52:34Z

only difference b/w normal and DEVEL IBs is boost version every thing else should be same.

smuzaffar · 2018-11-15T15:23:00Z

@slava77 , this is now merged for DEVEL IBs. Tonight's 23h DEVEL IB should have it.

slava77 · 2018-11-15T15:27:23Z

@slava77 , this is now merged for DEVEL IBs. Tonight's 23h DEVEL IB should have it.

thanks.
let's see if I manage to get to this in the next couple of days

cmsbuild · 2018-11-15T16:04:50Z

-1

Tested at: fe76dd5

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4452/31666/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

The relvals timed out after 2 hours.

cmsbuild · 2018-11-15T16:04:54Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

smuzaffar · 2018-11-26T20:31:17Z

@slava77 , did you find time to look in to this? DEVEL IBs should have it.

[10.2.X] updated root to cherry-pick changes to resolve memory over-w…

fe76dd5

…rite due to execution of a I/O root-project/root#2861

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Oct 26, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 26, 2018

cmsbuild added tests-rejected and removed tests-started labels Oct 27, 2018

cmsbuild added tests-pending and removed tests-rejected labels Oct 27, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 27, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 28, 2018

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Oct 28, 2018

cmsbuild added tests-approved and removed tests-started labels Nov 1, 2018

cmsbuild added tests-pending and removed tests-approved labels Nov 15, 2018

cmsbuild added tests-started and removed tests-pending labels Nov 15, 2018

smuzaffar changed the base branch from IB/CMSSW_10_4_X/gcc700 to IB/CMSSW_10_4_X/gcc700next November 15, 2018 15:16

smuzaffar merged commit 44ec98c into IB/CMSSW_10_4_X/gcc700next Nov 15, 2018

cmsbuild added tests-rejected and removed tests-started labels Nov 15, 2018

smuzaffar deleted the smuzaffar-patch-3 branch November 16, 2018 08:55

cmsbuild mentioned this pull request Jun 13, 2021

cleaning up unused py2 tools ; restoring tensorflow as part of python_tools.spec #7019

Merged

cmsbuild mentioned this pull request Jul 10, 2021

Update to python 3.9.6 #7111

Merged

cmsbuild mentioned this pull request Nov 21, 2022

SCRAM V2 disto via latest cmssw releases #8187

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.4.X] [ROOT] Cherry-pick changes to resolve memory over-write due to execution of a I/O #4452

[10.4.X] [ROOT] Cherry-pick changes to resolve memory over-write due to execution of a I/O #4452

smuzaffar commented Oct 26, 2018

smuzaffar commented Oct 26, 2018

cmsbuild commented Oct 26, 2018 •

edited

Loading

cmsbuild commented Oct 26, 2018

cmsbuild commented Oct 27, 2018

cmsbuild commented Oct 27, 2018

smuzaffar commented Oct 27, 2018

cmsbuild commented Oct 27, 2018 •

edited

Loading

cmsbuild commented Oct 28, 2018

cmsbuild commented Oct 28, 2018

cmsbuild commented Oct 28, 2018

smuzaffar commented Oct 28, 2018

cmsbuild commented Nov 1, 2018

cmsbuild commented Nov 1, 2018

cmsbuild commented Nov 1, 2018

smuzaffar commented Nov 15, 2018

cmsbuild commented Nov 15, 2018 •

edited

Loading

fabiocos commented Nov 15, 2018

smuzaffar commented Nov 15, 2018

slava77 commented Nov 15, 2018

smuzaffar commented Nov 15, 2018

slava77 commented Nov 15, 2018

smuzaffar commented Nov 15, 2018

smuzaffar commented Nov 15, 2018

slava77 commented Nov 15, 2018

cmsbuild commented Nov 15, 2018

cmsbuild commented Nov 15, 2018

smuzaffar commented Nov 26, 2018

[10.4.X] [ROOT] Cherry-pick changes to resolve memory over-write due to execution of a I/O #4452

[10.4.X] [ROOT] Cherry-pick changes to resolve memory over-write due to execution of a I/O #4452

Conversation

smuzaffar commented Oct 26, 2018

smuzaffar commented Oct 26, 2018

cmsbuild commented Oct 26, 2018 • edited Loading

cmsbuild commented Oct 26, 2018

cmsbuild commented Oct 27, 2018

cmsbuild commented Oct 27, 2018

smuzaffar commented Oct 27, 2018

cmsbuild commented Oct 27, 2018 • edited Loading

cmsbuild commented Oct 28, 2018

cmsbuild commented Oct 28, 2018

cmsbuild commented Oct 28, 2018

smuzaffar commented Oct 28, 2018

cmsbuild commented Nov 1, 2018

cmsbuild commented Nov 1, 2018

cmsbuild commented Nov 1, 2018

smuzaffar commented Nov 15, 2018

cmsbuild commented Nov 15, 2018 • edited Loading

fabiocos commented Nov 15, 2018

smuzaffar commented Nov 15, 2018

slava77 commented Nov 15, 2018

smuzaffar commented Nov 15, 2018

slava77 commented Nov 15, 2018

smuzaffar commented Nov 15, 2018

smuzaffar commented Nov 15, 2018

slava77 commented Nov 15, 2018

cmsbuild commented Nov 15, 2018

cmsbuild commented Nov 15, 2018

smuzaffar commented Nov 26, 2018

cmsbuild commented Oct 26, 2018 •

edited

Loading

cmsbuild commented Oct 27, 2018 •

edited

Loading

cmsbuild commented Nov 15, 2018 •

edited

Loading