Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Eigen compatibility with CUDA (10.4.x devel) #4381

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 27, 2018

Update Eigen to the master branch as of Tue Sep 25 20:26:16 2018 +0200

  • hg hash 66ba78bf7efa93f69a075830a87a010ed1b1fe30
  • git hash 01ae86b9aad30b1e65cf1b749fd6cd9a645ac00d

Patch Tensorflow to follow Eigen internal changes

  • cherry-pick changes from upstream repository
  • add local changes for the latest updates

Improve Eigen compatibility with CUDA

  • add support for cache-size queries on CUDA devices.
  • extend support for matrix inversion on CUDA devices above 4x4 matrices;
    the size of the matrices that can be inverted is limited at runtime by the per-thread stack size.
  • extend support for diagonal matrices on CUDA devices.
  • fix deprecation warning in CUDA 10.0.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_3_X/gcc700next.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 27, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30687/console

@fwyzard fwyzard force-pushed the IB/CMSSW_10_3_X/gcc700next_update_Eigen branch from 4388213 to 0947995 Compare September 27, 2018 12:07
@cmsbuild
Copy link
Contributor

Pull request #4381 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 27, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30691/console

@cmsbuild

This comment has been minimized.

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fwyzard fwyzard changed the title Improve Eigen compatibility with CUDA Improve Eigen compatibility with CUDA (10.3.x devel) Sep 28, 2018
@smuzaffar
Copy link
Contributor

please test

@cmsbuild

This comment has been minimized.

@cmsbuild

This comment has been minimized.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 3, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31461/console

@cmsbuild

This comment has been minimized.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 8, 2018

Do you have any idea why this fails, while the same changes (#4474) work on the standard IB ?

@davidlange6
Copy link
Contributor

davidlange6 commented Nov 8, 2018 via email

@davidlange6
Copy link
Contributor

davidlange6 commented Nov 8, 2018 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31533/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4381/31533/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-4381/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013827
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013629
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

lets get this in devel IBs and after 10.4.0.pre2 we can merged include it in normal IBs.

@smuzaffar smuzaffar merged commit 52175a1 into cms-sw:IB/CMSSW_10_4_X/gcc700next Nov 9, 2018
@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 9, 2018

Thanks.

I'd rather have it in pre2 than after, but I can bring it up at the next ORP (unless pre2 srrives before that).

@smuzaffar
Copy link
Contributor

@fabiocos wants to build pre2 over the weekend.

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 9, 2018

I see... I'd still be happy to have this in (it saves me from building the externals myself for Patatrack) but I won't complain if it enters after pre2...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants