-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Eigen compatibility with CUDA (10.4.x devel) #4381
Improve Eigen compatibility with CUDA (10.4.x devel) #4381
Conversation
A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_3_X/gcc700next. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
4388213
to
0947995
Compare
Pull request #4381 was updated. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
This comment has been minimized.
This comment has been minimized.
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This comment has been minimized.
This comment has been minimized.
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
Do you have any idea why this fails, while the same changes (#4474) work on the standard IB ? |
please test
… On Nov 8, 2018, at 2:09 PM, Andrea Bocci ***@***.***> wrote:
Do you have any idea why this fails, while the same changes (#4474) work on the standard IB ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
the error doesn't look related to eigen. lets try again
… On Nov 8, 2018, at 2:09 PM, Andrea Bocci ***@***.***> wrote:
Do you have any idea why this fails, while the same changes (#4474) work on the standard IB ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
lets get this in devel IBs and after 10.4.0.pre2 we can merged include it in normal IBs. |
Thanks. I'd rather have it in pre2 than after, but I can bring it up at the next ORP (unless pre2 srrives before that). |
@fabiocos wants to build pre2 over the weekend. |
I see... I'd still be happy to have this in (it saves me from building the externals myself for Patatrack) but I won't complain if it enters after pre2... |
Update Eigen to the master branch as of Tue Sep 25 20:26:16 2018 +0200
Patch Tensorflow to follow Eigen internal changes
Improve Eigen compatibility with CUDA
the size of the matrices that can be inverted is limited at runtime by the per-thread stack size.