Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update llvm/clang to version 7.0.0 (release) #4353

Merged
merged 6 commits into from
Sep 20, 2018
Merged

Update llvm/clang to version 7.0.0 (release) #4353

merged 6 commits into from
Sep 20, 2018

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 19, 2018 •
edited
Loading

Also

  • enable support for compiling CUDA code to NVPTX on amd64;
  • disable automatic package dependencies.

For the moment, skip building dxr, numba and llvmlite, until they support LLVM 7.

@fwyzard
Update llvm/clang to 7.0.0-svn342187 (release)
abc436f
@fwyzard
Update IWYU to the current master
7e5d3c4
@fwyzard
Disable automatic package dependencies
fbd34bf 
Llvm 7 includes a new tool, llvm-exegesis, that depepnds on libpfm.so.
Rather than including this library in the CMSSW stack, we assume that it
will be available form the host system; as it's not something strictly
necessary to have, we avoid a hard dependency on it in the RPM package.
@fwyzard
Enable support for compiling CUDA code on amd64
2e201d0
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_3_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fwyzard fwyzard mentioned this pull request Sep 19, 2018
Closed
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 19, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2018 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30523/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 7e5d3c4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4353/30523/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4353/30523/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3146746
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3146548
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 20, 2018

numba / llvmlite for clang 7 is tracked here: numba/llvmlite#396

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 20, 2018

As for DXR, we are using a revision that is 4 years old; the current version of DXR does not use trilite and sqlite, and instead relies on elasticsearch etc.

Would it make sense to try and update to the current version, rather than patching up the old one we use ?

@smuzaffar
Copy link
Contributor

@fwyzard , for now, we can merge this for DEVEL IB to get it fully tested.
About DXR, problem is the DXR server side setup. Newer DXR requires Elesticsearch. It was not a trivial update when last time we checked also was requiring too many resources (3GB/release in ES).

Anyway, I have made a PR ( fwyzard#1) to fix the dxr compilation with new llvm.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 20, 2018

Thanks, I will merge it and re-submit the tests.

About ElasticSearch, could we make use of the centralised CERN instance ?

@cmsbuild
Copy link
Contributor

Pull request #4353 was updated.

@fwyzard fwyzard force-pushed the IB/CMSSW_10_3_X/gcc700_llvm-7 branch from 920ee24 to ae11844 Compare September 20, 2018 14:02
@cmsbuild
Copy link
Contributor

Pull request #4353 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 20, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 20, 2018 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30531/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 03addaf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4353/30531/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4353/30531/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3146746
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3146547
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_10_3_X/gcc700 to IB/CMSSW_10_3_X/gcc700next September 20, 2018 20:41
@smuzaffar
Copy link
Contributor

smuzaffar commented Sep 20, 2018 •
edited
Loading

+externals
merging it for DEVEL IBs.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_3_X/gcc700next IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 2b61f61 into cms-sw:IB/CMSSW_10_3_X/gcc700next Sep 20, 2018
@smuzaffar smuzaffar mentioned this pull request Sep 24, 2018
Merged
@fwyzard fwyzard deleted the IB/CMSSW_10_3_X/gcc700_llvm-7 branch September 24, 2018 17:16
@fwyzard fwyzard mentioned this pull request Sep 28, 2018
Closed
@cmsbuild cmsbuild mentioned this pull request Jun 13, 2021
Merged
@cmsbuild cmsbuild mentioned this pull request Jul 10, 2021
Merged
@cmsbuild cmsbuild mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwyzard @cmsbuild @smuzaffar