Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.3.X] [Geant4]: Fixed muon stopping #4151

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

smuzaffar
Copy link
Contributor

backport of #4143
This include updates propose here: cms-externals/geant4#34

backport of #4143
This include updates propose here: cms-externals/geant4#34
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2018

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_9_3_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28865/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4151/28865/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 226
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624045
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29127/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4151/29127/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 225
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624046
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29594/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4151/29594/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 220
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624051
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Aug 1, 2018

@civanch I understand that this backport was suggested as a fix for rare crashes in production, so it makes sense to have it as we need to build a new 93X

@fabiocos
Copy link
Contributor

fabiocos commented Aug 1, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Aug 1, 2018

+externals

@fabiocos
Copy link
Contributor

fabiocos commented Aug 1, 2018

merge

@cmsbuild cmsbuild merged commit 318dd3e into IB/CMSSW_9_3_X/gcc630 Aug 1, 2018
@civanch
Copy link
Contributor

civanch commented Aug 1, 2018

@fabiocos , yes you are right.

@mrodozov
Copy link
Contributor

mrodozov commented Aug 1, 2018

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_3_X/gcc630 IBs (tests are also fine). This pull request will be automatically merged.

@smuzaffar smuzaffar deleted the smuzaffar-patch-3 branch August 28, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants