Python migration towards pth instead of PATHs #3874
Conversation
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_10_1_X/gcc630. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge
On 23 Mar 2018, at 22:28, cmsbuild <[email protected]<mailto:[email protected]>> wrote:
Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3874/27079/summary.html
Comparison Summary:
* No significant changes to the logs found
* Reco comparison results: 0 differences found in the comparisons
* DQMHistoTests: Total files compared: 29
* DQMHistoTests: Total histograms compared: 2498300
* DQMHistoTests: Total failures: 1
* DQMHistoTests: Total nulls: 0
* DQMHistoTests: Total successes: 2498123
* DQMHistoTests: Total skipped: 176
* DQMHistoTests: Total Missing objects: 0
* DQMHistoSizes: Histogram memory added: 0.930000000109 KiB( 22 files compared)
* Checked 118 log files, 9 edm output root files, 29 DQM output files
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#3874 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw9LrayqNX21fPtms35QPBRf0pd6uks5thWiqgaJpZM4S5Dp1>.
|
| py27List=`echo ${PYTHON27PATH} | tr ':' '\n'` | ||
|
|
||
| mkdir -p %{i}/${PYTHON_LIB_SITE_PACKAGES} | ||
| touch %{i}/${PYTHON_LIB_SITE_PACKAGES}/tool-deps.pth |
There was a problem hiding this comment.
@davidlange6 , we also need to relocate this file in %post otherwise it will have build paths instead of install.
Created a pth file with all cmssw python dependencies to reduce use of python envvars.
This required to stop using eggs, affecting only numpy and sqlalchemy builds. I changed those to use pip to build from source, making things a bit more consistent with the rest.
setting PYTHON27PATH ....cmssw-tool-conf//lib/python2.7/site-packages is now sufficient for all of the py2* tools (hooray). However, I did not yet enable that functionality. This would be the next step (purely a change of tool files, where a bunch of lines would be removed and one line added to the cmssw tool file)
The tensorflow changes were due to a missing setup tools dependency that they were previously picking up from py2-numpy.