-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add category xpog with no package associated for AN release branch management #954
Conversation
A new Pull Request was created by @fabiocos (Fabio Cossutti) for branch master. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
Pull request #954 was updated. |
@smuzaffar I added the new empty category and the associated responsible people, is anything more needed to have the possibility to assign a PR or an issue? |
Pull request #954 was updated. |
@smuzaffar thanks, but why is that syntax working at line 2 for "externals"? |
test_watcher.py was match the empty string to the package regexp. I updated the PR to have empty list instead of list with one empty string |
@fabiocos , because of https://github.com/cms-sw/cms-bot/blob/master/tests/test_watchers.py#L32 |
@smuzaffar thanks, I now see the special treatment :-) |
xpog category should be recognized now. Can you try doing "assign xpog" to some cmssw PR to see if it works and then if needed you can do "unassign xpog" |
@smuzaffar see cmssw issue cms-sw/cmssw#22358 |
thanks, looks fine. |
As agreed, a new empty category "xpog" with no CMSSW package associated is added, and the present XPOG coordinators are associated as responsible. This addition is intended to support the forthcoming AN release branch management, where the integration will be mostly done based on agreement from the XPOG coordinators (+ basic technical tests).