Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add category xpog with no package associated for AN release branch management #954

Merged
merged 3 commits into from
Feb 26, 2018

Conversation

fabiocos
Copy link
Contributor

As agreed, a new empty category "xpog" with no CMSSW package associated is added, and the present XPOG coordinators are associated as responsible. This addition is intended to support the forthcoming AN release branch management, where the integration will be mostly done based on agreement from the XPOG coordinators (+ basic technical tests).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for branch master.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

Pull request #954 was updated.

@fabiocos
Copy link
Contributor Author

@smuzaffar I added the new empty category and the associated responsible people, is anything more needed to have the possibility to assign a PR or an issue?
I must do something wrong in the syntax of categories_map.py, but I do not see what...

@cmsbuild
Copy link
Contributor

Pull request #954 was updated.

@fabiocos
Copy link
Contributor Author

@smuzaffar thanks, but why is that syntax working at line 2 for "externals"?

@smuzaffar
Copy link
Contributor

test_watcher.py was match the empty string to the package regexp. I updated the PR to have empty list instead of list with one empty string

@smuzaffar smuzaffar merged commit 2ba3dc1 into cms-sw:master Feb 26, 2018
@smuzaffar
Copy link
Contributor

@fabiocos , because of https://github.com/cms-sw/cms-bot/blob/master/tests/test_watchers.py#L32
I should fix the test_watcher.py to remove explicit checks for "externals" and use empty list for externals too.

@fabiocos
Copy link
Contributor Author

@smuzaffar thanks, I now see the special treatment :-)

@smuzaffar
Copy link
Contributor

xpog category should be recognized now. Can you try doing "assign xpog" to some cmssw PR to see if it works and then if needed you can do "unassign xpog"

@fabiocos
Copy link
Contributor Author

@smuzaffar see cmssw issue cms-sw/cmssw#22358

@smuzaffar
Copy link
Contributor

thanks, looks fine.

@fabiocos fabiocos deleted the fc-add-xpog branch March 12, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants