Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only reset signatures for modified files on dirty squash #2403

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Only reset signatures for modified files on dirty squash #2403

merged 1 commit into from
Dec 12, 2024

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider iarspider requested a review from smuzaffar December 12, 2024 13:19
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #2403 was updated.

smuzaffar
smuzaffar approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@smuzaffar smuzaffar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@smuzaffar
Copy link
Contributor

hopefully (in case of force push a different history) now bot should only reset the signatures for changes files

@smuzaffar
Copy link
Contributor

smuzaffar commented Dec 12, 2024 •
edited
Loading

+externals

tested at iarspider-cmssw/cmssw#23

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 0405411 into master Dec 12, 2024
8 of 9 checks passed
@smuzaffar smuzaffar mentioned this pull request Dec 13, 2024
Closed
@iarspider iarspider deleted the pr-squash-2 branch December 13, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuzaffar smuzaffar smuzaffar approved these changes

Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iarspider @cmsbuild @smuzaffar