Add option to run hlt p2 timing script for PRs #2240
Conversation
|
A new Pull Request was created by @iarspider for branch master. @cmsbuild, @aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
I do not see change in https://github.com/cms-sw/cms-bot/blob/master/pr_testing/test_multiple_prs.sh to run the new test |
|
Pull request #2240 was updated. |
|
And this is still not exactly right... |
|
Pull request #2240 was updated. |
|
Pull request #2240 was updated. |
|
enable hlt_p2_timing |
|
please test |
pr_testing/run-pr-hlt-p2-timing.sh
Outdated
|
|
||
| # Do work | ||
| timeout $TIMEOUT ${CMSSW_CVMFS_PATH}/src/HLTrigger/Configuration/python/HLT_75e33/test/runHLTTiming.sh 2>&1 | tee $WORKSPACE/hlt-p2-timing.log | ||
| CHART_URL="/circles/web/piechart.php?data_name=pr-hlt-p2-timing&resource=time_thread&filter=${UPLOAD_UNIQ_ID}&dataset=${UPLOAD_UNIQ_ID}/Phase2Timing_resources" |
There was a problem hiding this comment.
pr-hlt-p2-timing will not work. We need to upload the json files in the same directory as IBs
There was a problem hiding this comment.
Why mix IB and PR results?
There was a problem hiding this comment.
As far as I see, it's just a matter of adding a new symlink from PR testing area to /circles
There was a problem hiding this comment.
so that one can see both IB and PR tests in the drop down
pr_testing/test_multiple_prs.sh
Outdated
| @@ -1157,11 +1158,20 @@ if [ "X$BUILD_OK" = Xtrue -a "$RUN_TESTS" = "true" ]; then | |||
| DO_GPU_TESTS=true | |||
| mark_commit_status_all_prs 'unittests/gpu' 'pending' -u "${BUILD_URL}" -d "Waiting for tests to start" | |||
| fi | |||
| if [ $(echo ${ENABLE_BOT_TESTS} | tr ',' ' ' | tr ' ' '\n' | grep '^HLT_P2_TIMING$' | wc -l) -gt 0 ] ; then | |||
| if [ $(echo ${ARCHITECTURE} | grep "_amd64_" | wc -l) -gt 0 ] ; then | |||
| if [ -e ${CMSSW_CVMFS_PATH}/src/HLTrigger/Configuration/python/HLT_75e33/test/runHLTTiming.sh ]; then | |||
There was a problem hiding this comment.
please use $CMSSW_RELEASE_BASE instead of ${CMSSW_CVMFS_PATH} ( not that CMSSW_CVMFS_PATH is not accessible when this script is running. Output of this script gets deployed under CMSSW_CVMFS_PATH)
pr_testing/run-pr-hlt-p2-timing.sh
Outdated
| echo "HLT P2 timing: [chart](${CHART_URL})" > ${RESULTS_DIR}/hlt-p2-timing-report.res | ||
|
|
||
| mv WORKSPACE/Phase2Timing_resources*.json $WORKSPACE/testsResults | ||
| send_jenkins_artifacts $WORKSPACE/testsResults pr-hlt-p2-timing/${UPLOAD_UNIQ_ID} |
There was a problem hiding this comment.
upload it under hlt-p2-timing/<CMSSW_Version>+<RepoName><PRNUM>/$SCRAM_ARCH/${BUILD_NUMBER} e.g. hlt-p2-timing/CMSSW_14_1_X_2024-05-22-2300+cmssw44500/el8_amd64_gcc12/1234
|
Pull request #2240 was updated. |
|
please test |
|
Pull request #2240 was updated. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50770a/39500/summary.html HLT P2 timing: chart Comparison SummarySummary:
|
|
Pull request #2240 was updated. |
|
please test |
|
Pull request #2240 was updated. |
|
please test |
|
Pull request #2240 was updated. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50770a/39509/summary.html
Comparison SummarySummary:
|
|
FYI @rovere , this PR allows to enable hlt_p2_timing tests via either |
No description provided.