-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default wfs for PR tests on GPU in CMSSW_13_X_Y
#1976
Comments
A new Issue was created by @missirol Marino Missiroli. @Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
We could replace In principle we could skip |
Okay, so we would have
|
with #1977, bot should be able to select different relvals based on CMSSW version. We just need to add some condition like the following in https://github.com/cms-sw/cms-bot/blob/df771f1f82512b8f34eb796891beae0c0bb5cdab/cmssw-pr-test-config . Once you have the right set of workflows for GPUs then either update here or open a cms-bot PR (once #1977 is merged)
|
@smuzaffar, thanks. I think we can go with what is in #1976 (comment). I wrote something up, but it's probably wiser if I leave the implementation to you. if [ $(echo "${CMSSW_VERSION}" | awk -F 'CMSSW_|_' '{print $2}') -ge 13 ]; then
PR_TEST_MATRIX_EXTRAS_GPU=12434.586,12434.587
else
PR_TEST_MATRIX_EXTRAS_GPU=11634.586,11634.587
fi |
Thanks @smuzaffar ! |
cms-sw/cmssw#41354 and cms-sw/cmssw#41371 added GPU RelVals for 2023 conditions in
CMSSW_13_1_Y
andCMSSW_13_0_X
, respectively.I think that, ideally, PR tests on GPU should run by default
12434.506,12434.512,12434.522
(2023 wfs) inCMSSW_13_X_Y
, and11634.506,11634.512,11634.522
(2022 wfs) in earlier release cycles, which is what is already happening.@fwyzard, what do you think?
@smuzaffar, would this be possible? (I don't know how
cmsbot
differentiates between release cycles)The text was updated successfully, but these errors were encountered: