Skip to content

Commit

Permalink
fix nano comparison url; add size comparison
Browse files Browse the repository at this point in the history
  • Loading branch information
smuzaffar committed Oct 19, 2022
1 parent 6fa35e1 commit 430f27c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pr_testing/run-pr-comparisons
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,10 @@ ${CMS_BOT_DIR}/report-pull-request-results "COMPARISON_READY" --report-url ${PR_
if [ "${TEST_FLAVOR}" != "" ] ; then
sed -i -e "s|## Comparison Summary|## ${UC_TEST_FLAVOR} Comparison Summary|" $WORKSPACE/testsResults/20-comparison-report.res
mv $WORKSPACE/testsResults/20-comparison-report.res $WORKSPACE/testsResults/20-${TEST_FLAVOR}-comparison-report.res
if [ -e $WORKSPACE/upload/NANO_report.md ] ; then
echo "- Nano Size comparison results" >> $WORKSPACE/testsResults/20-${TEST_FLAVOR}-comparison-report.res
cat $WORKSPACE/upload/NANO_report.md >> $WORKSPACE/testsResults/20-${TEST_FLAVOR}-comparison-report.res
fi
fi

if [ "$DRY_RUN" = "" ] ; then
Expand Down
7 changes: 7 additions & 0 deletions templates/js/renderPRTests.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ getResultRow = function( resultsDict , resultsKey ){
column2Label = 'See High Stats Comparison Results'
linkURL = BASE_COMPARISONS_HIGH_STATS_URL + resultsDict[ BASE_IB_KEY ] + '+' + resultsDict[ PR_NUMBER_KEY ] + '/' + testResult + '/'

}else if( resultsKey == COMPARISON_NANO ){

column2Label = 'See Nano Comparison Results'
linkURL = BASE_COMPARISONS_NANO_URL + resultsDict[ BASE_IB_KEY ] + '+' + resultsDict[ PR_NUMBER_KEY ] + '/' + testResult + '/'

}


Expand Down Expand Up @@ -212,6 +217,7 @@ PR_NUMBERS_KEY = 'PR_NUMBERS';
COMPARISON_KEY = 'COMPARISON';
COMPARISON_GPU_KEY = 'COMPARISON_GPU';
COMPARISON_HIGH_STATS = 'COMPARISON_HIGH_STATS';
COMPARISON_NANO = 'COMPARISON_NANO';
BASE_IB_URL = '/SDT/html/showIB.html';
COMPARISON_IB_KEY = "COMPARISON_IB"
IB_PAGE_V2 = '/SDT/html/cmssdt-ib/#/ib/';
Expand All @@ -224,4 +230,5 @@ LOCATIONS = {};
BASE_COMPARISONS_URL = '/SDT/@JENKINS_PREFIX@-artifacts/baseLineComparisons/';
BASE_COMPARISONS_GPU_URL = '/SDT/@JENKINS_PREFIX@-artifacts/baseLineComparisonsGPU/';
BASE_COMPARISONS_HIGH_STATS_URL = '/SDT/@JENKINS_PREFIX@-artifacts/baseLineComparisonsHIGH_STATS/'
BASE_COMPARISONS_NANO_URL = '/SDT/@JENKINS_PREFIX@-artifacts/baseLineComparisonsNANO/'

0 comments on commit 430f27c

Please sign in to comment.