Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed embedded BaseTagInfo in pat::Jet #9

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Removed embedded BaseTagInfo in pat::Jet #9

merged 1 commit into from
Nov 21, 2023

Conversation

Dr15Jones
Copy link

PR description:

The interface to add an embedded object was removed in 2010 and the member data was only kept to read very old files.

PR validation:

Code compiles.

@Dr15Jones
Removed embedded BaseTagInfo in pat::Jet
65bd015 
The interface to add an embedded object was removed in 2010 and
the member data was only kept to read very old files.
@Dr15Jones Dr15Jones requested a review from nsmith- November 21, 2023 19:32
nsmith-
nsmith- approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@nsmith- nsmith- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It compiles for me as well, and I can confirm that I can copy the new pat::Jet data product to a new file.

@nsmith- nsmith- merged commit 94eda7e into cms-rntuple-work:CMSSW_14_0_0_pre0_modified Nov 21, 2023
@nsmith- nsmith- mentioned this pull request Nov 21, 2023
Open
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsmith- nsmith- nsmith- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dr15Jones @nsmith-