forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RefToBase to Ptr conversion for pat::TriggerObjectStandAlone #5
Merged
nsmith-
merged 7 commits into
cms-rntuple-work:CMSSW_14_0_0_pre0_modified
from
nsmith-:ref2ptr
Nov 28, 2023
Merged
RefToBase to Ptr conversion for pat::TriggerObjectStandAlone #5
nsmith-
merged 7 commits into
cms-rntuple-work:CMSSW_14_0_0_pre0_modified
from
nsmith-:ref2ptr
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmith-
changed the title
General RefToBase to Ptr conversion
RefToBase to Ptr conversion for pat::TriggerObjectStandAlone
Nov 20, 2023
Deprecate any API methods that return RefToBase
makortel
reviewed
Nov 20, 2023
Dr15Jones
requested changes
Nov 21, 2023
@nsmith- were you able to test that the IO rule worked? |
It worked but only because every RefToBase is null. Indeed the misspelled (non-ioread) function would have caused an error if the member was filled. (that's how I ran into it for |
Co-authored-by: Chris Jones <[email protected]>
@nsmith- as long as you confirm this compiled, I'm fine with merging. |
Dr15Jones
approved these changes
Nov 28, 2023
It compiles, yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implemented two templated methods:
refToBaseToPtr
for use in class constructors, etc., where the desire is to keep the RefToBase API available, and thenrefToBaseToPtr_ioread
to be used exclusively inioread
rules to do schema migration of data written with the old type.Validation:
Managed to forward-copy the data products:
but I cannot verify if non-null
origObjCand()
is working, since it appears thePATTriggerProducer
default value forsaveL1Refs
is false, and this is not overridden in MiniAOD production (despite l1extra being in MiniAOD)