Fix clang warnings #387

makortel · 2019-09-13T16:10:14Z

PR description:

This PR fixes the clang warnings reported in cms-sw#27983 (comment).

While compiling with clang, it complained about the alignas in SiPixelFedCablingMapGPU.h I fixed those as well.

PR validation:

Code compiles.

Fixes clang errors

…leted

makortel · 2019-09-13T16:12:28Z

RecoLocalCalo/EcalRecAlgos/interface/DeclsForKernels.h

 class EcalSampleMask;
 class EcalTimeBiasCorrections;
-class EcalPulseCovariance;
+struct EcalPulseCovariance;


@vkhristenko Does this (and below) conflict with your ECAL developments?

if you mean forward decl changing class -> struct - should be fine. i see original one is a struct, therefore definitely should be fine.

I was more thinking if your PR/developments are touching the same lines (for whatever reason) and thus leading to git merge conflicts.

Ah, forward decls should be fine (line-wise).

fwyzard · 2019-10-16T13:54:49Z

Validation summary

Reference release CMSSW_11_0_0_pre7 at 411b633
Development branch CMSSW_11_0_X_Patatrack at 1a357a8
Testing PRs:

Fix clang warnings #387 at d1c0d1a

`makeTrackValidationPlots.py` plots

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 10824.5
tracking validation plots and summary for workflow 10824.51
tracking validation plots and summary for workflow 10824.52

/RelValZMM_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 10824.5
tracking validation plots and summary for workflow 10824.51
tracking validation plots and summary for workflow 10824.52

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_design_v3-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 10824.5
tracking validation plots and summary for workflow 10824.51
tracking validation plots and summary for workflow 10824.52

logs and `nvprof`/`nvvp` profiles

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

reference release, workflow 10824.5
- ✔️ step3.py: log
development release, workflow 10824.5
- ✔️ step3.py: log
development release, workflow 10824.51
- ✔️ step3.py: log
development release, workflow 10824.52
- ✔️ step3.py: log
- ✔️ profile.py: log, visual profile and summary
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 10824.5
- ✔️ step3.py: log
testing release, workflow 10824.51
- ✔️ step3.py: log
testing release, workflow 10824.52
- ✔️ step3.py: log
- ❌ profile.py: log, visual profile and summary
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors

/RelValZMM_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

reference release, workflow 10824.5
- ✔️ step3.py: log
development release, workflow 10824.5
- ✔️ step3.py: log
development release, workflow 10824.51
- ✔️ step3.py: log
development release, workflow 10824.52
- ✔️ step3.py: log
- ✔️ profile.py: log, visual profile and summary
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 10824.5
- ✔️ step3.py: log
testing release, workflow 10824.51
- ✔️ step3.py: log
testing release, workflow 10824.52
- ✔️ step3.py: log
- ✔️ profile.py: log, visual profile and summary
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_design_v3-v1/GEN-SIM-DIGI-RAW

reference release, workflow 10824.5
- ✔️ step3.py: log
development release, workflow 10824.5
- ✔️ step3.py: log
development release, workflow 10824.51
- ✔️ step3.py: log
development release, workflow 10824.52
- ✔️ step3.py: log
- ✔️ profile.py: log, visual profile and summary
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 10824.5
- ✔️ step3.py: log
testing release, workflow 10824.51
- ✔️ step3.py: log
testing release, workflow 10824.52
- ✔️ step3.py: log
- ✔️ profile.py: log, visual profile and summary
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/e04d9e2bf189aa12180fac38b2d0f7e539b92bfe/log .

fwyzard · 2019-10-23T07:13:29Z

Throughput

makortel added 10 commits September 13, 2019 16:57

Use alignas properly

6e05a39

Fixes clang errors

Exlicitly delete copy operations because as implicit they would be de…

2e35ad8

…leted

Remove unused variable

e53383d

Remove unnecessary std::move that prevented copy elision

46e3382

Remove unnecessary std::move that prevented copy elision

c26aa39

Fix include guards

1f5a50e

Remove unnecessary std::move that prevented copy elision

9542c14

Use override keyword

798d9d9

Use struct consistently

7f16e7f

Remove unnecessary std::move that prevented copy elision

d1c0d1a

makortel commented Sep 13, 2019

View reviewed changes

fwyzard merged commit 2b9431d into cms-patatrack:CMSSW_11_0_X_Patatrack Oct 23, 2019

fwyzard mentioned this pull request Aug 13, 2020

Patatrack integration - GPU beamspot data format and transfer (4/N) cms-sw/cmssw#31130

Merged

fwyzard pushed a commit that referenced this pull request Oct 8, 2020

Fix clang warnings (#387)

d91d687

fwyzard pushed a commit that referenced this pull request Oct 8, 2020

Fix clang warnings (#387)

fec3995

fwyzard pushed a commit that referenced this pull request Oct 8, 2020

Fix clang warnings (#387)

b28a74f

fwyzard pushed a commit that referenced this pull request Oct 8, 2020

Fix clang warnings (#387)

ebd2c0b

This was referenced Oct 8, 2020

Patatrack integration - ECAL local reconstruction (7/N) cms-sw/cmssw#31719

Merged

Patatrack integration - Pixel local reconstruction (9/N) cms-sw/cmssw#31721

Merged

Patatrack integration - Pixel track reconstruction (10/N) cms-sw/cmssw#31722

Merged

fwyzard pushed a commit that referenced this pull request Oct 19, 2020

Fix clang warnings (#387)

f3d25dc

fwyzard pushed a commit that referenced this pull request Oct 20, 2020

Fix clang warnings (#387)

4ca209b

fwyzard pushed a commit that referenced this pull request Oct 20, 2020

Fix clang warnings (#387)

6e80758

fwyzard pushed a commit that referenced this pull request Oct 20, 2020

Fix clang warnings (#387)

c97cc04

fwyzard pushed a commit that referenced this pull request Oct 23, 2020

Fix clang warnings (#387)

c714a90

fwyzard pushed a commit that referenced this pull request Oct 23, 2020

Fix clang warnings (#387)

25bd8fc

fwyzard pushed a commit that referenced this pull request Nov 6, 2020

Fix clang warnings (#387)

c2a91da

fwyzard pushed a commit that referenced this pull request Nov 6, 2020

Fix clang warnings (#387)

1d5f516

fwyzard pushed a commit that referenced this pull request Nov 6, 2020

Fix clang warnings (#387)

e9b667d

fwyzard pushed a commit that referenced this pull request Nov 9, 2020

Fix clang warnings (#387)

fe535d6

fwyzard pushed a commit that referenced this pull request Nov 12, 2020

Fix clang warnings (#387)

302eb20

fwyzard pushed a commit that referenced this pull request Nov 16, 2020

Fix clang warnings (#387)

8fa8dd9

fwyzard pushed a commit that referenced this pull request Nov 16, 2020

Fix clang warnings (#387)

e1366d5

fwyzard pushed a commit that referenced this pull request Nov 16, 2020

Fix clang warnings (#387)

a78bf6e

fwyzard added a commit that referenced this pull request Nov 27, 2020

Fix clang warnings (#387)

1ee0943

fwyzard added a commit that referenced this pull request Nov 27, 2020

Fix clang warnings (#387)

c9f598c

fwyzard pushed a commit that referenced this pull request Dec 25, 2020

Fix clang warnings (#387)

0fcdf5a

fwyzard pushed a commit that referenced this pull request Dec 25, 2020

Fix clang warnings (#387)

1d61155

fwyzard pushed a commit that referenced this pull request Dec 26, 2020

Fix clang warnings (#387)

3829a5e

fwyzard mentioned this pull request Dec 26, 2020

Patatrack integration - Pixel vertex reconstruction (11/N) cms-sw/cmssw#31723

Merged

fwyzard pushed a commit that referenced this pull request Dec 29, 2020

Fix clang warnings (#387)

1d70875

fwyzard pushed a commit that referenced this pull request Dec 29, 2020

Fix clang warnings (#387)

950358b

fwyzard pushed a commit that referenced this pull request Dec 29, 2020

Fix clang warnings (#387)

419aa82

fwyzard pushed a commit that referenced this pull request Jan 13, 2021

Fix clang warnings (#387)

c3d51e4

fwyzard pushed a commit that referenced this pull request Jan 15, 2021

Fix clang warnings (#387)

240c4d6

fwyzard pushed a commit that referenced this pull request Mar 23, 2021

Fix clang warnings (#387)

0b6b228

fwyzard pushed a commit that referenced this pull request Apr 1, 2021

Fix clang warnings (#387)

604a797

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix clang warnings #387

Fix clang warnings #387

makortel commented Sep 13, 2019

makortel Sep 13, 2019

vkhristenko Sep 16, 2019

makortel Sep 16, 2019

vkhristenko Sep 16, 2019

fwyzard commented Oct 16, 2019 •

edited

Loading

fwyzard commented Oct 23, 2019

Fix clang warnings #387

Fix clang warnings #387

Conversation

makortel commented Sep 13, 2019

PR description:

PR validation:

makortel Sep 13, 2019

Choose a reason for hiding this comment

vkhristenko Sep 16, 2019

Choose a reason for hiding this comment

makortel Sep 16, 2019

Choose a reason for hiding this comment

vkhristenko Sep 16, 2019

Choose a reason for hiding this comment

fwyzard commented Oct 16, 2019 • edited Loading

Validation summary

makeTrackValidationPlots.py plots

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_design_v3-v1/GEN-SIM-DIGI-RAW

logs and nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_realistic_v4-v1/GEN-SIM-DIGI-RAW

/RelValTTbar_13/CMSSW_10_6_0-PU25ns_106X_upgrade2018_design_v3-v1/GEN-SIM-DIGI-RAW

Logs

fwyzard commented Oct 23, 2019

Throughput

fwyzard commented Oct 16, 2019 •

edited

Loading

`makeTrackValidationPlots.py` plots

logs and `nvprof`/`nvvp` profiles