Create CUDA events for CUDAProduct only when needed #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not create event if the CUDA stream is idle, i.e. has already finished all work that was queued, at the point when data products are wrapped/emplaced for/to edm::Event. When creating an event, create only a single event per producer, i.e. all products of a producer share the same event. Also include a unit test checking the assumed behavior of CUDA events and streams.
|
|
|
No impact on the throughput, running on a P100: |
fwyzard
pushed a commit
that referenced
this pull request
May 15, 2019
Don't leave nCuts in VIDNestedWPBitmapProducer uninitialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not create event if the CUDA stream is idle, i.e. has already
finished all work that was queued, at the point when data products are
wrapped/emplaced for/to
edm::Event.When creating an event, create only a single event per producer, i.e.
all products of a producer share the same event.
Fixes #287.