Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~gpu ? #133

Closed
fwyzard opened this issue Aug 14, 2018 · 3 comments
Closed

~gpu ? #133

fwyzard opened this issue Aug 14, 2018 · 3 comments
Assignees
Labels

Comments

@fwyzard
Copy link

fwyzard commented Aug 14, 2018

@makortel , can you think of a way to get rid of the (~gpu) modifier in Configuration/StandardSequences/python/RawToDigi_cff.py ?

@makortel
Copy link

To first order it is needed a it is.

Nevertheless, possible ways to remove it are

@makortel
Copy link

The latest version of #100 will remove the (~gpu).

@fwyzard
Copy link
Author

fwyzard commented Mar 18, 2019

Fixed by #100.

@fwyzard fwyzard closed this as completed Mar 18, 2019
@fwyzard fwyzard added the fixed label Mar 18, 2019
fwyzard pushed a commit that referenced this issue May 5, 2020
* enable alternative output data types in TauDiscriminationProducerBase and create one

* add class dictionaries

* add template argument for input type of TauDiscriminationProducerBase

* change RecoTauDiscriminantCutMultiplexer to write all WPs into one dataformat

* update configs

* adapt PAT Tau Producer to new reco Tau Discriminator format

* fix handling of config inputs and clean up

* fix expected input type

* special treatment of taus that failed prediscriminant during reco production

* pipe through discr raw value even if no category found

* small fix in PAT Tau ID config

* fix tau ID indexing

* reenable usage of preDiscriminantFailValue in TauDiscriminationProducerBase

* update TauTagValidation

* update event content config

* adapt switchMVAtoDB_cfi

* fix typo

* store vector of rawValues in TauDiscriminatorContainer

* use new dataformat in discriminator raw value production

* install new dataformat in anti muon discriminator

* adapt PFRecoTauDiscriminationByIsolation to new data format

* add new data format for PAT tau discriminators

* prepare tau ID producer base for new data format with pat taus

* merge ID cut multiplexer for reco and pat taus into a templated version

* switch from double to float for raw values in new data format

* add IDname to fillDescriptions of cut based IDs

* remove depracated cut based IDs and rearrange inheritance chain in configs accordingly

* add fillDescription defaults to cut based ID definitions

* move photonPtSumOutsideSignalCone options to WP configs

* add IDname parameter to AntiMuonDiscr fillDescr

* some fixes at producer level

* update reco configs

* switch back to usage of category float only if needed

* update PAT step and apply some fixes

* introduce new data format in remaining ID producers operating on MiniAOD

* enable PATTauIDEmbedder to process new data format

* adapt configs of ID producers running on MiniAOD to new data format

* update data format in remaining external modules

* fix antiEleID rebase

* change name of Tau ID Container Base Class

* fix some issues revealed by the matrix tests

* move deepTauID to new data format

* complete adaptation of deepTau config and HLT related things, clean up

* complete previous rebase

* make PAT ID mapping sensitive to input tag instance

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants