Fix nanoAOD default config for 2018 without era (94X version, to check it doesn't change anything in 94X) #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetruc
changed the title
gpetruc
changed the title
gpetruc-bot
added
test scheduled (bot)
test started (bot)
and removed
to be tested by bot
test scheduled (bot)
labels
|
Automatic test started, see https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/436596/builds |
gpetruc-bot
added
scram unit test failed (bot)
and removed
scram unit test failed (bot)
labels
gpetruc-bot
suggested changes
Jul 5, 2018
There was a problem hiding this comment.
Automatic test report for 436596
- gitlab pipeline at https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/436596/builds
- status: FAILURE (see link above for failed jobs)
Code integration
Code checks not run for this PR (no source files modified)
Tests
- Test mc_94Xv2: passed
- Test mc_94X: passed
- Test mc_80X: passed
- Test data_94Xv2: passed
- Test data_94X: passed
- Test data_80X: passed
gpetruc-bot
added
test failed (bot)
test started (bot)
and removed
test started (bot)
labels
|
Automatic test started, see https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/436809/builds |
gpetruc-bot
reviewed
Jul 5, 2018
There was a problem hiding this comment.
Automatic test report for 436809
- gitlab pipeline at https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/436809/builds
- outputs at https://cms-nanoaod-integration.web.cern.ch/integration/test_pr_179/
Code integration
Code checks not run for this PR (no source files modified)
Tests
- Long test data80X (10000 events): passed, no significant changes; dqm plots: all, diff
- Long test data80Xhip (3000 events): passed, no significant changes; dqm plots: all, diff
- Long test data94X (10000 events): passed, no significant changes; dqm plots: all, diff
- Long test data94Xv2 (10000 events): passed, no significant changes; dqm plots: all, diff
- Long test mc80X (10000 events): passed, no significant changes; dqm plots: all, diff
- Long test mc94X (10000 events): passed, no significant changes; dqm plots: all, diff
- Long test mc94Xv2 (9000 events): passed, no significant changes; dqm plots: all, diff
- Test mc_94Xv2: passed
- Test mc_94X: passed
- Test mc_80X: passed
- Test data_94Xv2: passed
- Test data_94X: passed
- Test data_80X: passed
Disk size report
| Sample | kb/event | ref kb/event | diff |
|---|---|---|---|
| TTbar MC 94Xv1 | 1.572 | 1.572 | -0.000 ( -0.0% ) |
| TTbar MC 94Xv2 | 1.605 | 1.604 | 0.001 ( +0.1% ) |
| TTbar MC 80X | 1.610 | 1.609 | 0.001 ( +0.0% ) |
| Data 94Xv1 | 0.631 | 0.631 | -0.000 ( -0.0% ) |
| Data 80X | 0.580 | 0.580 | 0.000 ( +0.0% ) |
| Data 80X, Mu Run2016E | 0.577 | 0.577 | 0.000 ( +0.0% ) |
|
will merge even if it has no effect, to help keep master and 94X more similar and rebases easier |
This was referenced Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
94X version of cms-sw#23749 for testing