Phase-2 L1T: Fix GT packed format for Correlator e/gamma and tau objects #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloeliger
added
Phase-2
|
@cerminar We are trying to use Otherwise the content looks fine. @epalencia I see you've commented on the CMSSW version, I will let you sign there. Any comments for here, or should we just merge it once rebased? |
|
Yes, this can be merged once rebased (and master PR is signed already). |
4 tasks
epalencia
added a commit
that referenced
this pull request
Nov 6, 2023
Phase-2 L1T: Fix GT packed format for Correlator e/gamma and tau objects #1168
|
I'm closing this PR as the 13_3 rebased version already exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR addresses a bug in converting the hardware data format used in the Correlator to the GT one.
The corresponding PR to master is cms-sw#43075