Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT Emulator] First cleaned version AMv2 with SL2 #1163

Conversation

jfernan2
Copy link

@jfernan2 jfernan2 commented Oct 11, 2023

PR description:

This PR integrates the new version (v2) of the Analytical Method for the Phase-2 DT Emulator.

It has been presented in the DT Upgrade (trigger primitives and test systems)[1] and in the Level-1 Muon DPG meeting [2].

Needs data files from PR cms-data/L1Trigger-DTTriggerPhase2#3

Credits of the code to @jaimeleonh [3], SL2 emulation addition from [4]

PR validation:

The software goes hand by hand with the developments being implemented in the firmware. In links [1] and [2] are presented performance results with the new AMv2 algorithm :

  • In simulation with the emulator
  • Comparing emulator and firmware in the laboratory
  • Similar (or even improved) performance w.r.t. previous AM version (v1, already in CMSSW)

[1] https://indico.cern.ch/event/1262475/contributions/5308462/attachments/2607937/4505149/230309_NewAM_DTUpgrade_JLH.pdf
[2] https://indico.cern.ch/event/1263362/contributions/5305755/attachments/2607489/4504221/230308_NewAM_L1MuonDPG_JLH.pdf

[3] https://github.com/jaimeleonh/cmssw/tree/AM_12_4_2_new_fitter
[4] https://github.com/jfernan2/cmssw/tree/AM_12_4_2_new_fitter_withThetas

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -j 8

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 check-headers

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

  • L1Trigger/L1CaloTrigger/plugins/L1EGammaCrystalsEmulatorProducer.cc

Please run scram b code-format to auto-apply code formatting

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

@epalencia epalencia added the Phase-2 Pertains to phase-2 development label Oct 13, 2023
@epalencia
Copy link

Thanks @jfernan2 for porting this PR to 13_3 (#1166). I'm closing this one.

@epalencia epalencia closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phase-2 Pertains to phase-2 development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants