Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMTF muon shower unpacker update (backport of PR41993) #1146

Conversation

epalencia
Copy link

This PR fixes a bunch of things in muon shower unpacking in EMTF. It's not critical for data taking, but it will be good to backport it so we can improve monitoring of this trigger for 2023.

The changes are as follows:

  • Changed the internal name of the trigger from HMT to "muon shower" or "MUS". This is done for consistency with other L1T trigger producers
  • Added a proper way of creating CSCShowerDigi in EMTF unpacker. This was mostly done to adjust the BX value associated with the shower (but also follows the same pattern with other EMTF inputs)
  • Added support for new loose shower bit in unpacked EMTF outputs
  • Removed pure muon shower objects from EMTF hit and track collections. This should fix the unnecessary LogWarning messages originating from EMTF unpacker or emulator

There will be a PR to include the BX value in EMTF emulator (and potentially uGMT as well) in the future, but for now I wanted to keep these separate.

Backport of cms-sw#41993.

epalencia and others added 2 commits June 28, 2023 18:15
…SCShowerDigi with correct BX in EMTFHit. Remove muon showers from EMTF Hit and Track collections to prevent warning messages. Rename HMT to MUS or muon shower to prevent confusion

(cherry picked from commit 8913c8b)
@epalencia epalencia added Phase-1 Pertains to phase-1 development Backport For backported content labels Jun 29, 2023
@epalencia epalencia merged commit 180937e into cms-l1t-offline:l1t-integration-CMSSW_13_1_0_pre4 Jun 29, 2023
@epalencia
Copy link
Author

Tagged as l1t-integration-v161.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport For backported content Phase-1 Pertains to phase-1 development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants