Update muon shower (un)packers for 2023 running (Backport of 41172) #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-offline with cms-merge-topic
(cherry picked from commit a83ed09)
|
Hi @epalencia, Just to make sure: I think you'll also need the PR with the modified data formats (cms-sw#40890) too. Cheers, |
|
Hi @dinyar, 408900 is included in 13_1_0_pre 2 already, it should have been included in the IB when doing the rebase, no? |
|
Oh, sorry hadn't checked that. :-) |
aloeliger
added
Phase-1
|
Tagged as l1t-integration-v150. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of cms-sw#41172.
Added logic to the (un)packers to deal with the new "two loose showers" bit that will be used in 2023. The logic for those changes is gated behind either the firmware version that was extracted from the readout record or by the era.