Fix incorrect hadronic shower packing and enable global shower unpacking for both uGMT and uGT [Backport of 36877] #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were generating this error by looking at the wrong bits. (cherry picked from commit 507daaf)
Two out of six words from the payload are used for showers, we were unfortunately off by one. (cherry picked from commit 6f588db)
Also make error message if we're in danger of overwriting data with muon shower info more useful. (cherry picked from commit f0cc084)
This didn't actually break anything, but caused confusing errors when trying to pack (always empty) showers for OMTF. (cherry picked from commit eff0144)
(cherry picked from commit 9f45a6c)
(cherry picked from commit e1487ac)
(cherry picked from commit acd64c3)
(cherry picked from commit 5bf734e)
(cherry picked from commit 7ff8aa5)
|
This PR avoids these warnings during step 3: |
cecilecaillol
merged commit 74130b4
into
cms-l1t-offline:phase2-l1t-integration-1230pre4
|
tagged as l1t-phase2-v3.4.41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 36877: Fix incorrect hadronic shower packing and enable global shower unpacking for both uGMT and uGT