Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev objects #56

Merged
merged 96 commits into from
Feb 5, 2024
Merged

Dev objects #56

merged 96 commits into from
Feb 5, 2024

Conversation

danielhundhausen
Copy link
Collaborator

  • usage of centrally defined objects for performance and rate plots
  • automatic dumping and loading of the scalings (automated interface between obj performance and rate plots)

@danielhundhausen
add working version of objects class utility and electron configuration
5e1cb0b
@danielhundhausen
develop objects
8b500e4
@danielhundhausen
fix jets_matching plots; remove old versions
f76232f
@danielhundhausen
edit jets trigger config to fit new object style
73b9f29
@danielhundhausen
fix code quality issues
f464ac4
@danielhundhausen
remove from object config and put it back into plot configuration
609a661
@danielhundhausen
fix instructions wrongly referring to requirements.txt
dd8b511
@danielhundhausen
fix electron isolation plots
8ddbd0c
@danielhundhausen
update ele matching eta plots to use central objects; bugfix
edcd693
@danielhundhausen
update remaining electron obj perf configs to use central objects; ad…
417df36 
…d more parsing/warnings to config class
@danielhundhausen
add name of plot that is misconfigured to exception messages in plot …
358bb39 
…config
@danielhundhausen
fixes; more config parsing; jet config adaptation
d3f8946
@danielhundhausen
write jet and met/mht configs to use central objects
8940321
@danielhundhausen
fix sample configuration in jet_matching V29
c200899
@danielhundhausen
fix mht plots by converting to Mementum4D after cutting
2853202
@danielhundhausen
configure muon matching with central obj definitions
b9d2f14
@danielhundhausen
finish re-configuration of muons with central objects
78c2163
@danielhundhausen
reconfigure photon iso reproducing iso plots
68ffbe5
@danielhundhausen
continue photon configuration
ea09f82
@danielhundhausen
reconfigure photon matching with central objects
b5750d8
@danielhundhausen
reconfigure photon trigger plots with central objects
0546a05
@danielhundhausen
Fix range nameing convention in electron objects and implement phton …
3c9f5b1 
…qual125
@danielhundhausen
reconfigure tau machting wHH with central tau objects
46ebe5f
@danielhundhausen
finish taus
16563cc
@danielhundhausen
add poetry.lock files as recommended by poetry docs
5260a71
@danielhundhausen
fix suffix of config dump that lead to overwriting plot jsons
e245145
@danielhundhausen
enable wildcard for object performance plotting solving cms-l1-dpg#47
128237e
@danielhundhausen
fix isoloation electron plots
4a52791
@danielhundhausen
fixes in electrons config
28d8a6c
@danielhundhausen
copy rate plot code and config from
e8fc897
danielhundhausen and others added 29 commits January 30, 2024 17:01
@danielhundhausen
some minor fixes
5329918
@danielhundhausen
introduce CLI shortcuts for running and
643b65e
@danielhundhausen
Fix V29 gmtTkMuon definition: no quality < 8 GeV
cf650b2
@danielhundhausen
Fix the inclusive ranges and cuts in the v29 objects
62628ec
@danielhundhausen
fix bug where slope and offset were swapped
5c0955d
@danielhundhausen
fix edgecase where phi could be 0
adde35e
@danielhundhausen
clean up rate plot conifg for V29
94015e4
@danielhundhausen
remove debugging printouts
7f088f7
@danielhundhausen
fix entryopnits for cli interface
1d6ff55
@danielhundhausen
clean up rate config
c317edb
@danielhundhausen
fix bug where selection did not work for objects without phi field
8a87145
@danielhundhausen
add ht to rate plot config
81a9784
@danielhundhausen
replace progress with tqdm
98472c0
@danielhundhausen
add shortcut entry point
ca4084a
@artlbv
add json dump for rate plotter
a239f32
@artlbv
make rate computer more efficient by avoiding looping over thresholds…
0a50812 
… and using cumsum
@artlbv
remove EG eleID
2bbef70
@artlbv
fix Muon quality ID
acf95cf
@artlbv
restrict tkPhoton eta to 2.4
2454228
@danielhundhausen
remove non-existant HT branch from caching config
2248130
@danielhundhausen
update documentation
8c11d3a
@danielhundhausen
Merge pull request #17 from artlbv/dev_objects_artur
f7a8a94 
add json dump for rate plotter
@danielhundhausen
add seededConePuppiHT to rate plot
c833a7f
@danielhundhausen
make nicer progress bar
8719d26
@danielhundhausen
merge
655dc56
@danielhundhausen
remove unused import; reforamt; fix type hint
f2b09ca
@danielhundhausen
fix HT (event level) rate plots
38ec098
@danielhundhausen
add dump of rate plot config
a6a90b1
@danielhundhausen
add test to rate plots
df4a5e0
@danielhundhausen danielhundhausen merged commit 00d6811 into cms-l1-dpg:refactored_tools Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonanomi bonanomi Awaiting requested review from bonanomi

@artlbv artlbv Awaiting requested review from artlbv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielhundhausen @artlbv