Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move objectPerformance contents to new structure #48

Conversation

danielhundhausen
Copy link
Collaborator

All the contents of objectPerformance were move to the appropriate places in the new structure of the python project. caching and object_performance are now split into two distinct submodules of menu_tools. The functionality of caching and object_performance was tested and is unchanged.

The from object_performance is now saved at outputs/object_performance.

The configuration files can now be found under configs/object_performance_plots.

@artlbv
Copy link
Collaborator

artlbv commented Jan 15, 2024

Thanks!
I think we wanted to have a common config for each version, e.g. V29 containting cache/objects/rates.
Do you want to change that later or should it be changed here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file needed?

Copy link
Collaborator Author

@danielhundhausen danielhundhausen Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the modern version setup.py. Here is the documentation regarding it. I think we can get rid of either setup.py or pyproject.toml if we so desire. I had it in objectPerformance up till now and only moved it one layer up. I suggest we create a ticket for this.

@danielhundhausen
Copy link
Collaborator Author

Thanks! I think we wanted to have a common config for each version, e.g. V29 containting cache/objects/rates. Do you want to change that later or should it be changed here?

I have updated this.

@artlbv artlbv added this to the NewMenuTools milestone Jan 16, 2024
@danielhundhausen
Copy link
Collaborator Author

Since there is a new awkward version that fixes the bug we found, I have updated the ak version to 2.5.2 and produced a number of comparison plots to the old version that confirms that everything still closes.

@danielhundhausen danielhundhausen changed the base branch from main to refactored_tools January 16, 2024 14:17
@danielhundhausen danielhundhausen merged commit bb6d9aa into cms-l1-dpg:refactored_tools Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants