-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move objectPerformance contents to new structure #48
Move objectPerformance contents to new structure #48
Conversation
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this file needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the modern version setup.py
. Here is the documentation regarding it. I think we can get rid of either setup.py
or pyproject.toml
if we so desire. I had it in objectPerformance
up till now and only moved it one layer up. I suggest we create a ticket for this.
I have updated this. |
Since there is a new awkward version that fixes the bug we found, I have updated the ak version to 2.5.2 and produced a number of comparison plots to the old version that confirms that everything still closes. |
All the contents of
objectPerformance
were move to the appropriate places in the new structure of the python project.caching
andobject_performance
are now split into two distinct submodules ofmenu_tools
. The functionality of caching andobject_performance
was tested and is unchanged.The from
object_performance
is now saved atoutputs/object_performance
.The configuration files can now be found under
configs/object_performance_plots
.