Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Info class so that weights do now grow with every re-init #14

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Conversation

smrenna
Copy link
Contributor

@smrenna smrenna commented Sep 9, 2019

Chris Jones convinced me to do a pull request instead ;).;

@cmsbuild
Copy link

cmsbuild commented Sep 9, 2019

A new Pull Request was created by @smrenna (Stephen Mrenna) for branch cms/240.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link

please test

@cmsbuild
Copy link

cmsbuild commented Sep 10, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2441/console Started: 2019/09/10 09:47

@cmsbuild
Copy link

Comparison job queued.

@cmsbuild
Copy link

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b4749/2441/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2957224
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2956881
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@fabiocos
Copy link

@smrenna do you consider this as a fix to be integrated in future pythia8 releases?

@smrenna
Copy link
Contributor Author

smrenna commented Sep 10, 2019 via email

@fabiocos
Copy link

+1

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link

This pull request is fully signed and it will be integrated in one of the next cms/240 IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 7109c9c into cms-externals:cms/240 Sep 12, 2019
mrodozov added a commit to cms-sw/cmsdist that referenced this pull request Sep 12, 2019
fabiocos added a commit to fabiocos/cmsdist that referenced this pull request Sep 12, 2019
fabiocos added a commit to fabiocos/cmsdist that referenced this pull request Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants