Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin MarkupSafe to 2.0.1 (#33) #1211

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Conversation

SvizelPritula
Copy link
Contributor

Cherry-pick commit e718c62 from ioi2022/cms, which should fix tests breaking due to beaking changes in MarkupSafe.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1211 (ec8a2ec) into master (0401c53) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1211      +/-   ##
==========================================
- Coverage   63.88%   63.66%   -0.22%     
==========================================
  Files         233      233              
  Lines       17151    17151              
==========================================
- Hits        10957    10920      -37     
- Misses       6194     6231      +37     
Flag Coverage Δ
functionaltests 47.53% <ø> (-0.23%) ⬇️
unittests 43.98% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cms/plugin.py 81.81% <0.00%> (-18.19%) ⬇️
cms/service/workerpool.py 66.11% <0.00%> (-6.12%) ⬇️
cms/service/ScoringService.py 68.18% <0.00%> (-6.07%) ⬇️
cms/db/base.py 88.11% <0.00%> (-2.98%) ⬇️
cms/server/admin/handlers/base.py 68.31% <0.00%> (-2.98%) ⬇️
cms/service/EvaluationService.py 74.62% <0.00%> (-2.49%) ⬇️
cms/server/contest/handlers/contest.py 86.40% <0.00%> (-1.95%) ⬇️
cms/io/service.py 72.78% <0.00%> (-1.27%) ⬇️
cms/grading/scoring.py 79.06% <0.00%> (-1.17%) ⬇️
cms/service/ResourceService.py 59.11% <0.00%> (-0.89%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@myungwoo
Copy link
Contributor

⬆️

@wil93
Copy link
Member

wil93 commented Dec 11, 2022

Thanks! I'm taking a look into this issue, a quick feedback in the meantime: I think it would be preferable to avoid adding MarkupSafe as a dependency since it's not actually a dependency for us (it's a dependency of one of our dependencies, Jinja2) so maybe it would be cleaner to solve this by upgrading Jinja2 instead.

@wil93 wil93 merged commit bbef0ac into cms-dev:master Dec 15, 2022
@wil93
Copy link
Member

wil93 commented Dec 15, 2022

Merged like this for now, as it seems that the only other solution would be pinning all dependencies (e.g. using pip-tools or pipenv) and we can do that at a later time. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants