Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the AddSubmission script #1178

Merged
merged 1 commit into from
May 13, 2021
Merged

Conversation

MaGaroo
Copy link
Contributor

@MaGaroo MaGaroo commented May 13, 2021

Edit help message of the --contest-id argument

The name of the script is "Add Submission" but there is "id of contest where to add the user" in the help message. So I thought that would've been a mistake.


This change is Reviewable

Edit help message of the `--contest-id` argument
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1178 (9a1ff46) into master (ed4e05f) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
+ Coverage   63.44%   63.61%   +0.17%     
==========================================
  Files         232      232              
  Lines       17046    17046              
==========================================
+ Hits        10815    10844      +29     
+ Misses       6231     6202      -29     
Flag Coverage Δ
functionaltests 47.63% <ø> (+0.15%) ⬆️
unittests 44.05% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmscontrib/AddSubmission.py 73.73% <ø> (ø)
cms/service/ScoringService.py 68.18% <0.00%> (-1.52%) ⬇️
cms/io/service.py 71.51% <0.00%> (-1.22%) ⬇️
cms/service/ResourceService.py 59.11% <0.00%> (-0.89%) ⬇️
cms/db/fsobject.py 75.75% <0.00%> (-0.76%) ⬇️
cms/db/submission.py 97.93% <0.00%> (-0.52%) ⬇️
cms/grading/Job.py 88.83% <0.00%> (-0.45%) ⬇️
cms/io/rpc.py 94.21% <0.00%> (ø)
cms/server/admin/handlers/base.py 69.63% <0.00%> (ø)
cms/server/contest/handlers/contest.py 87.37% <0.00%> (+0.97%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed4e05f...9a1ff46. Read the comment docs.

@andreyv
Copy link
Member

andreyv commented May 13, 2021

Thanks, indeed this looks like a mistake. Merging.

@andreyv andreyv merged commit f3b5de9 into cms-dev:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants