Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate cms.pot file #1114

Merged
merged 1 commit into from
Feb 23, 2019
Merged

Regenerate cms.pot file #1114

merged 1 commit into from
Feb 23, 2019

Conversation

lw
Copy link
Member

@lw lw commented Feb 18, 2019

I first reverted the {% -> {%+ change as that doesn't appear to be compatible with Babel's extracter, then ran ./setup.py extract_messages.


This change is Reviewable

@lw lw requested a review from stefano-maggiolo February 18, 2019 21:27
@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #1114 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1114      +/-   ##
==========================================
- Coverage   61.99%   61.93%   -0.06%     
==========================================
  Files         230      230              
  Lines       16591    16591              
==========================================
- Hits        10285    10276       -9     
- Misses       6306     6315       +9
Flag Coverage Δ
#functionaltests 45.76% <ø> (+0.14%) ⬆️
#unittests 43.26% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
cms/db/base.py 85.1% <0%> (-4.26%) ⬇️
cms/service/esoperations.py 77.3% <0%> (-3.55%) ⬇️
cms/grading/Job.py 85.78% <0%> (-3.32%) ⬇️
cms/io/PsycoGevent.py 65.71% <0%> (-2.86%) ⬇️
cms/server/admin/handlers/base.py 67.11% <0%> (-2.04%) ⬇️
cms/server/admin/handlers/task.py 39.84% <0%> (-1.18%) ⬇️
cms/db/util.py 51.11% <0%> (-0.75%) ⬇️
cms/server/admin/handlers/dataset.py 25.38% <0%> (-0.31%) ⬇️
cms/io/rpc.py 91.46% <0%> (ø) ⬆️
cms/service/ProxyService.py 57.97% <0%> (+0.53%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af70934...20f7b7b. Read the comment docs.

I first reverted the `{%` -> `{%+` change as that doesn't appear to be
compatible with Babel's extracter, then ran `./setup.pt
extract_messages`.
@lw
Copy link
Member Author

lw commented Feb 23, 2019

Rebased and updated this.

@stefano-maggiolo
Copy link
Member

LGTM

@lw lw merged commit 7be645b into cms-dev:master Feb 23, 2019
@lw lw deleted the pot_master branch February 23, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants