Ensure compiled translation .mo files are picked up during build phase #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug where simply running `./setup.py install` from a fresh checkout would compile the .po files into .mo files but wouldn't copy them to the `build/` subdirectory. Running `build` then `install` (or running `install` twice) would fix that issue as the files compiled by the first pass would get picked up at the second one. This issue didn't affect the `develop` mode, since there the "installed" package is just a symlink to the source tree, where these files exist.
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
- Coverage 62.05% 61.98% -0.08%
==========================================
Files 228 228
Lines 16437 16437
==========================================
- Hits 10200 10188 -12
- Misses 6237 6249 +12
Continue to review full report at Codecov.
|
|
LGTM given after private discussion. |
|
Merged into master and v1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where simply running
./setup.py installfrom a fresh checkout would compile the .po files into .mo files but wouldn't copy them to thebuild/subdirectory. Runningbuildtheninstall(or runninginstalltwice) would fix that issue as the files compiled by the first pass would get picked up at the second one.This issue didn't affect the
developmode, since there the "installed" package is just a symlink to the source tree, where these files exist.This needs to be backported to v1.4.
This change is