Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deeplinking of users in RWS #1037

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

stefano-maggiolo
Copy link
Member

@stefano-maggiolo stefano-maggiolo commented Oct 4, 2018

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #1037 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
- Coverage   62.29%   62.28%   -0.02%     
==========================================
  Files         227      227              
  Lines       16562    16562              
==========================================
- Hits        10317    10315       -2     
- Misses       6245     6247       +2
Flag Coverage Δ
#functionaltests 46.28% <ø> (-0.05%) ⬇️
#unittests 43.36% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cms/service/ProxyService.py 58.51% <0%> (-3.2%) ⬇️
cms/io/service.py 66.46% <0%> (-2.4%) ⬇️
cms/db/base.py 86.59% <0%> (-2.07%) ⬇️
cms/server/admin/handlers/base.py 67.79% <0%> (-1.7%) ⬇️
cms/server/admin/handlers/dataset.py 25.61% <0%> (-0.62%) ⬇️
cms/server/admin/handlers/task.py 42.41% <0%> (-0.39%) ⬇️
cms/service/EvaluationService.py 67.63% <0%> (-0.27%) ⬇️
cms/db/filecacher.py 77.22% <0%> (+0.33%) ⬆️
cms/grading/Sandbox.py 68.34% <0%> (+0.35%) ⬆️
cms/io/rpc.py 91.15% <0%> (+1.02%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fcc1da...ca4c90c. Read the comment docs.

Copy link
Member

@lw lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@stefano-maggiolo stefano-maggiolo merged commit ca4c90c into cms-dev:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants