Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update per-iteration JSON files for mkFit configuration (121X) #3

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

mmasciov
Copy link
Contributor

@mmasciov mmasciov commented Aug 16, 2021

Update of per-iteration JSON files for mkFit configuration, as per PR cms-sw/cmsdist#7217 and cms-sw/cmssw#34921

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for branch main.

@perrotta, @smuzaffar, @iarspider, @mrodozov, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@mmasciov mmasciov marked this pull request as ready for review August 17, 2021 17:34
@jpata
Copy link

jpata commented Aug 19, 2021

+reconstruction

@mrodozov
Copy link
Contributor

+externals

@mrodozov
Copy link
Contributor

abort

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next main IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@mrodozov
Copy link
Contributor

@jpata this is good to get in regardless of the cmssw PR ?

@jpata
Copy link

jpata commented Aug 20, 2021

I believe this should be merged just before the corresponding CMSSW PR. For the moment we can wait until that one is signed.

@jpata
Copy link

jpata commented Aug 23, 2021

@mrodozov from the reco point of view, this could be merged now, concurrently with cms-sw/cmssw#34921 (once it's fully signed).

@mrodozov
Copy link
Contributor

I was asking if this is final so we can tag it and prepare the cmsdist change

@mmasciov
Copy link
Contributor Author

I was asking if this is final so we can tag it and prepare the cmsdist change

Just to confirm that no further change is expected before the next pre-release.
All changes for the next pre-release are in this PR, together with cms-sw/cmsdist#7229 and cms-sw/cmssw#34921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants