Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Models for Doublet-Recovery using Winter24 DY+Jpsi #7

Merged
merged 1 commit into from
May 28, 2024

Conversation

wonpoint4
Copy link

Add new MuonHLT Seed Classifier model files for the Muon doublet-recovery.
Here are relevant JIRA ticket for this change, and slides in TSG meeting on 1st May.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wonpoint4 for branch main.

@cmsbuild, @mandrenguyen, @iarspider, @aandvalenzuela, @jfernan2, @smuzaffar can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2024

cms-bot internal usage

@mmusich
Copy link

mmusich commented May 25, 2024

@cmsbuild, please test

  • even though there's nothing to test (yet)

@mmusich
Copy link

mmusich commented May 25, 2024

type hlt-integration

@mandrenguyen
Copy link

+1
Guess we don't need to wait until tests pass

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-830841/39525/summary.html
COMMIT: 8e80f53
CMSSW: CMSSW_14_1_X_2024-05-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/RecoMuon-TrackerSeedGenerator/7/39525/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 854
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3337988
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link

mmusich commented May 27, 2024

@iarspider, @aandvalenzuela, @smuzaffar can you please sign this for externals?

@iarspider
Copy link

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

smuzaffar commented May 27, 2024

@mmusich , This PR just adds new data files, is there any cmssw PR to test/use these new files?

@mmusich
Copy link

mmusich commented May 27, 2024

This PR just adds new data files, is there any cmssw PR to test/use these new files?

@smuzaffar, not yet - this PR is needed to update the HLT menu and the PR that will do that will come at a later time.

@antoniovilela
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants