Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeepMET model files #5

Merged
merged 2 commits into from
May 18, 2020
Merged

Add DeepMET model files #5

merged 2 commits into from
May 18, 2020

Conversation

steggema
Copy link
Contributor

@steggema steggema commented May 7, 2020

This adds 5 model files for DeepMET:
2018 training, both regular and response-corrected;
2016 training, only response-corrected;
and phase 2 training, both regular and response-corrected.

The concurrent cms-sw PR is here cms-sw/cmssw#29764

@intrepid42 @yongbinfeng

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

A new Pull Request was created by @steggema (Jan Steggemann) for branch master.

@perrotta, @smuzaffar, @mrodozov, @cmsbuild, @slava77, @tulamor can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @ahinzmann, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
cms-bot commands are listed here

@slava77
Copy link

slava77 commented May 7, 2020

@steggema
please add a README.md or txt in the deepmet subdirectory to briefly describe the files.

@mrodozov
Copy link

please test with cms-sw/cmssw#29764

@cmsbuild
Copy link
Contributor

cmsbuild commented May 11, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29764
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6220/console Started: 2020/05/11 15:31

@cmsbuild
Copy link
Contributor

+1
Tested at: c935aa8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3fcda/6220/summary.html
CMSSW: CMSSW_11_1_X_2020-05-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 11, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29764
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6223/console Started: 2020/05/11 17:30

@cmsbuild
Copy link
Contributor

Pull request #5 was updated.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3fcda/6220/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697178
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

+1
Tested at: c935aa8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1bf30/6223/summary.html
CMSSW: CMSSW_11_1_X_2020-05-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1bf30/6333/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2702162
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2701841
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29764
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6391/console Started: 2020/05/18 15:56

@cmsbuild
Copy link
Contributor

+1
Tested at: 9c06715
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1bf30/6391/summary.html
CMSSW: CMSSW_11_1_X_2020-05-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1bf30/6391/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 50 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694414
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@slava77
Copy link

slava77 commented May 18, 2020

+1

based on cms-sw/cmssw#29764

@smuzaffar
Copy link
Contributor

+externals
only new files, so can be merged and integrated in next IB

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants