Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit with CNN-based energy regression and ID tf model. #1

Merged
merged 5 commits into from
Sep 25, 2019
Merged

Initial commit with CNN-based energy regression and ID tf model. #1

merged 5 commits into from
Sep 25, 2019

Conversation

riga
Copy link
Contributor

@riga riga commented Jul 29, 2019 •
edited
Loading

This PR adds an initial tensorflow model for energy regression and particle identification that is used in the HGCal reconstruction. The model is described in detail in this talk given at the last Patatrack Hackathon.

In addition, I added a few links to the README for easy navigation.

Edit: The cms-sw/cmssw PR for this is cms-sw/cmssw#27917.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @riga (Marcel R.) for branch master.

@perrotta, @smuzaffar, @mrodozov, @kpedro88, @cmsbuild, @slava77, @gudrutis can you please review it and eventually sign? Thanks.
@felicepantaleo, @clelange this is something you requested to watch as well.
cms-bot commands are listed here

@slava77
Copy link

slava77 commented Jul 29, 2019

@riga
is there a cms-sw/cmssw PR for this?

@riga
Copy link
Contributor Author

riga commented Jul 29, 2019

@slava77 I will open the PR within the next 90 minutes.

@felicepantaleo
Copy link
Contributor

@rovere fyi

@riga riga mentioned this pull request Jul 29, 2019
Closed
@cmsbuild
Copy link
Contributor

Pull request #1 was updated.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27634

@cmsbuild cmsbuild mentioned this pull request Jul 31, 2019
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2019 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27634,cms-sw/cmsdist#5120
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1747/console Started: 2019/07/31 17:45

@cmsbuild
Copy link
Contributor

+1
Tested at: 1407d1b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-494f01/1747/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-494f01/1747/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-494f01/22034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D46_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D46+RecoFullGlobal_2026D46+HARVESTFullGlobal_2026D46

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2484130
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2483812
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 132 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Collaborator

+externals

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9a975/2566/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2957336
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2956994
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 23, 2019 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27917,cms-sw/cmsdist#5120
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2621/console Started: 2019/09/23 14:12

@cmsbuild
Copy link
Contributor

+1
Tested at: 197566b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9a975/2621/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9a975/2621/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2958092
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2957750
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@fabiocos
Copy link

@perrotta @kpedro88 as you have signed cms-sw/cmssw#27917 I assume you approve this PR as well (in any case it only adds new files, it does not modify anything already existing)

@fabiocos
Copy link

+1

@fabiocos
Copy link

merge

@cmsbuild cmsbuild merged commit 1e9fc29 into cms-data:master Sep 25, 2019
@smuzaffar
Copy link
Collaborator

+externals

@cmsbuild cmsbuild mentioned this pull request Sep 25, 2019
Closed
smuzaffar added a commit to cms-sw/cmsdist that referenced this pull request Sep 25, 2019
@smuzaffar
Update tag for RecoHGCal-TICL to V00-01-00
51a59ad 
Move RecoHGCal-TICL data to new tag, see
cms-data/RecoHGCal-TICL#1
@smuzaffar smuzaffar mentioned this pull request Sep 25, 2019
Merged
@kpedro88
Copy link

+upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-approved orp-approved pending-signatures reconstruction-pending requires-external tests-approved upgrade-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@riga @cmsbuild @slava77 @felicepantaleo @smuzaffar @fabiocos @kpedro88